feat: Setting to allow Sales Order creation against expired quotation #33952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested review from
nextchamp-saqib and
ruthra-kumar
as code owners
deepeshgarg007
added
backport version-13-hotfix
backport version-14-hotfix
…w_sales_order_creation_for_expired_quotation
deepeshgarg007
force-pushed
the
allow_sales_order_creation_for_expired_quotation
branch
from
8df05d8
to
c78be7b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33952 +/- ##
========================================
Coverage 63.86% 63.87%
========================================
Files 818 818
Lines 59307 59312 +5
========================================
+ Hits 37879 37883 +4
- Misses 21428 21429 +1
|
deepeshgarg007
added a commit
that referenced
this pull request
Feb 13, 2023
…#33952) * feat: Setting to allow Sales Order creation against expired quotation (#33952) * feat: Setting to allow Sales Order creation against expired quotation * chore: linting issues (cherry picked from commit 148703b) # Conflicts: # erpnext/selling/doctype/selling_settings/selling_settings.json * chore: Resolve conflicts --------- Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
# [14.16.0](v14.15.1...v14.16.0) (2023-02-14) ### Bug Fixes * `amount` in `Material Request` ([f1dd923](f1dd923)) * `get_picked_items_details` ([7afbd92](7afbd92)) * `pymysql.err.ProgrammingError` ([aa3dd33](aa3dd33)) * Add missing 1 required positional argument: 'bill_date' ([ced9274](ced9274)) * add payment hook to point of sale JS ([#33988](#33988)) ([49fd712](49fd712)) * allow PI cancel if linked asset is cancelled ([c98b2b5](c98b2b5)) * Amount for debit and credit notes with 0 qty line items ([#33902](#33902)) ([87a8c17](87a8c17)) * Amount validation in Payment Request against Purchase Order ([#34042](#34042)) ([c7c6123](c7c6123)) * BOM import failed as importer use same label field for Raw MaterialsItem table and Scrap Item table ([47d17f4](47d17f4)) * Concurrency issues in Sales and Purchase returns ([#34019](#34019)) ([087333a](087333a)) * consider `stock_qty` if `picked_qty` is zero ([df72e4a](df72e4a)) * consider existing pick list ([466a791](466a791)) * currency formatting in item-wise sales history ([#33903](#33903)) ([8e2d7bb](8e2d7bb)) * default due_date was wrong calculated on template "_Test Payment Term Template 1" (last day of next month) ([c8c9c50](c8c9c50)) * **ecommerce:** throw invalid doctype error in shop by category ([#33901](#33901)) ([1d0e71b](1d0e71b)) * failed test, convert date time to string ([7228a49](7228a49)) * german chart of accounts "SKR03" ([#33909](#33909)) ([02c4c55](02c4c55)) * Ignore mandatory fields while creating tax templates for new companies ([#34005](#34005)) ([b0ed3c8](b0ed3c8)) * Ignore Payment Ledger Entry on dunning cancel (backport [#34025](#34025)) ([#34028](#34028)) ([699e93e](699e93e)) * incorrect actual qty in Bin ([01ff6a1](01ff6a1)) * IntegrityError while cancelling journals against cr note ([c71d035](c71d035)) * list view for Terms and Conditions ([#33925](#33925)) ([bb8e232](bb8e232)) * negative stock error ([e0cd6c2](e0cd6c2)) * set per_billed based on hours when amounts are zero ([#33984](#33984)) ([5270fbe](5270fbe)) * should never get cutomer price on purchase document ([#34002](#34002)) ([6fe7600](6fe7600)), closes [#33998](#33998) * stock entry from item dashboard (stock levels) ([04a474d](04a474d)) * **test:** `test_pick_list_for_items_with_multiple_UOM()` ([7124c0c](7124c0c)) * unwanted difference amount calculation on cr note and invoice with same currency ([#34020](#34020)) ([cbafc51](cbafc51)) ### Features * Add filters in Loan Interest Report ([#33907](#33907)) ([52bfb66](52bfb66)) * add incoterm named place to RFQ ([68a1615](68a1615)) * mandatory and mandatory depends on in inventory dimension ([3aca84c](3aca84c)) * Setting to allow Sales Order creation against expired quotation ([#33952](#33952)) ([4d0e27e](4d0e27e)) ### Performance Improvements * reduce memory usage by paging through records ([3ce8dc7](3ce8dc7)) * reduce memory usage while migrating remarks ([c191a3f](c191a3f))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
# [13.46.0](v13.45.1...v13.46.0) (2023-02-14) ### Bug Fixes * `amount` in `Material Request` ([813e8bb](813e8bb)) * allow PI cancel if linked asset is cancelled ([fbeaabf](fbeaabf)) * conflicts ([a9f5be3](a9f5be3)) * currency formatting in item-wise sales history ([#33903](#33903)) ([f641039](f641039)) * Debit and Credit not equal while submitting PI containing asset item ([#33092](#33092)) ([5be4c6f](5be4c6f)) * german chart of accounts "SKR03" ([#33909](#33909)) ([b2a3e01](b2a3e01)) * incorrect actual qty in Bin ([8f42833](8f42833)) * LWP calculation ([c1de4e4](c1de4e4)) * negative stock error ([2f4ffe1](2f4ffe1)) * stock entry from item dashboard (stock levels) ([8106c64](8106c64)) * **UX:** make Item attachments public by default (backport [#32196](#32196)) ([#33949](#33949)) ([124d7de](124d7de)) * validate working day list against holidays ([a8ea3ef](a8ea3ef)) ### Features * Setting to allow Sales Order creation against expired quotation ([#33952](#33952)) ([f04542e](f04542e))
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
…frappe#33952) * feat: Setting to allow Sales Order creation against expired quotation (frappe#33952) * feat: Setting to allow Sales Order creation against expired quotation * chore: linting issues (cherry picked from commit 148703b) # Conflicts: # erpnext/selling/doctype/selling_settings/selling_settings.json * chore: Resolve conflicts --------- Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
# [13.46.0](frappe/erpnext@v13.45.1...v13.46.0) (2023-02-14) ### Bug Fixes * `amount` in `Material Request` ([813e8bb](frappe@813e8bb)) * allow PI cancel if linked asset is cancelled ([fbeaabf](frappe@fbeaabf)) * conflicts ([a9f5be3](frappe@a9f5be3)) * currency formatting in item-wise sales history ([frappe#33903](frappe#33903)) ([f641039](frappe@f641039)) * Debit and Credit not equal while submitting PI containing asset item ([frappe#33092](frappe#33092)) ([5be4c6f](frappe@5be4c6f)) * german chart of accounts "SKR03" ([frappe#33909](frappe#33909)) ([b2a3e01](frappe@b2a3e01)) * incorrect actual qty in Bin ([8f42833](frappe@8f42833)) * LWP calculation ([c1de4e4](frappe@c1de4e4)) * negative stock error ([2f4ffe1](frappe@2f4ffe1)) * stock entry from item dashboard (stock levels) ([8106c64](frappe@8106c64)) * **UX:** make Item attachments public by default (backport [frappe#32196](frappe#32196)) ([frappe#33949](frappe#33949)) ([124d7de](frappe@124d7de)) * validate working day list against holidays ([a8ea3ef](frappe@a8ea3ef)) ### Features * Setting to allow Sales Order creation against expired quotation ([frappe#33952](frappe#33952)) ([f04542e](frappe@f04542e))
Closed
BevanTony1
pushed a commit
to BevanTony1/eso-erpnext
that referenced
this pull request
Mar 23, 2023
# [13.46.0](frappe/erpnext@v13.45.1...v13.46.0) (2023-02-14) ### Bug Fixes * `amount` in `Material Request` ([813e8bb](frappe@813e8bb)) * allow PI cancel if linked asset is cancelled ([fbeaabf](frappe@fbeaabf)) * conflicts ([a9f5be3](frappe@a9f5be3)) * currency formatting in item-wise sales history ([frappe#33903](frappe#33903)) ([f641039](frappe@f641039)) * Debit and Credit not equal while submitting PI containing asset item ([frappe#33092](frappe#33092)) ([5be4c6f](frappe@5be4c6f)) * german chart of accounts "SKR03" ([frappe#33909](frappe#33909)) ([b2a3e01](frappe@b2a3e01)) * incorrect actual qty in Bin ([8f42833](frappe@8f42833)) * LWP calculation ([c1de4e4](frappe@c1de4e4)) * negative stock error ([2f4ffe1](frappe@2f4ffe1)) * stock entry from item dashboard (stock levels) ([8106c64](frappe@8106c64)) * **UX:** make Item attachments public by default (backport [frappe#32196](frappe#32196)) ([frappe#33949](frappe#33949)) ([124d7de](frappe@124d7de)) * validate working day list against holidays ([a8ea3ef](frappe@a8ea3ef)) ### Features * Setting to allow Sales Order creation against expired quotation ([frappe#33952](frappe#33952)) ([f04542e](frappe@f04542e))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no-docs