fix: currency in coa import #34174
Merged
fix: currency in coa import #34174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishnu7025
requested review from
nextchamp-saqib,
deepeshgarg007 and
ruthra-kumar
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34174 +/- ##
===========================================
- Coverage 64.05% 64.05% -0.01%
===========================================
Files 810 810
Lines 59307 59309 +2
===========================================
Hits 37992 37992
- Misses 21315 21317 +2
|
deepeshgarg007
pushed a commit
that referenced
this pull request
Feb 27, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 28, 2023
## [14.17.2](v14.17.1...v14.17.2) (2023-02-28) ### Bug Fixes * conversion factor not set ([089c7d0](089c7d0)) * currency in coa import ([#34174](#34174)) ([4d92d46](4d92d46)) * default date in Subcontracting reports ([5fce8e2](5fce8e2)) * german translations ([#31732](#31732)) ([88a781f](88a781f)) * incorrect acc depr amount if multiple FBs with straight line or manual method ([dda6bae](dda6bae)) * incorrect color in the BOM Stock Report ([001ed9e](001ed9e)) * manual depr schedule ([971c072](971c072)) * multiple pos conversion issue resolved ([db964e8](db964e8)) * not able to repost gl entries ([ae0318e](ae0318e)) * permission error while calling get_work_order_items ([3ea90ee](3ea90ee)) * pos return throwing amount greater than grand total ([9cd7b27](9cd7b27)) * Remove missing DocField in fetch_from ([dc6ae46](dc6ae46)) * set `from_warehouse` and `to_warehouse` while mapping SE ([80e23d0](80e23d0)) * **test:** use standalone method to fetch work orders from SO ([1719884](1719884)) * ui freeze on item selection in sales invoice ([1750ed4](1750ed4)) * user shouldn't able to make item price for item template ([fb8e45d](fb8e45d)) * zero division error while making LCV ([1859be6](1859be6)) ### Performance Improvements * fetch SLE's on demand and memoize ([db1f17e](db1f17e)) ### Reverts * Revert "fix: Concurrency issues in Sales and Purchase returns" (#34202) ([9341d3e](9341d3e)), closes [#34202](#34202) [#34019](#34019)
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added currency column in Chart of Accounts Importer