fix: based on status_update.py update opportunity status to converted… #35145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wondered if this type of treatment should be carried out in a personalized way according to the client... Why can there be cases where the customer considers it converted when the order is placed, in other cases when it is invoiced... But what led to this change was looking at the status_updater.py for the Opportunity |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #35145 +/- ##
========================================
Coverage 63.69% 63.69%
========================================
Files 813 813
Lines 60064 60065 +1
========================================
+ Hits 38258 38259 +1
Misses 21806 21806
|
deepeshgarg007
added
backport version-13-hotfix
backport version-14-hotfix
|
@HarryPaulo There is a function to check if the opportunity has any ordered quotation named |
|
@deepeshgarg007, Currently in Quotation, the Opportunity status only changes on: on_cancel, on_submit... As I am making a sales order, it does not change the status, so my change was made. |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
## [14.27.2](v14.27.1...v14.27.2) (2023-06-14) ### Bug Fixes * `enqueue_after_commit` wherever it makes sense (backport [#35588](#35588)) ([#35590](#35590)) ([e505516](e505516)) * `TypeError` in Closing Stock Balance ([32e5bbb](32e5bbb)) * **accounts:** validate payment entry references with latest data. ([#31166](#31166)) ([4add1b4](4add1b4)) * added process loss in job card ([6a21d61](6a21d61)) * allow user to set rounding loss allowance for accounts balance ([cf14858](cf14858)) * attribute error on payment reconciliation tool ([25b3c77](25b3c77)) * based on status_update.py update opportunity status to converted… ([#35145](#35145)) ([dee8275](dee8275)) * calculate wdv depr schedule properly for existing assets [v14] ([#35613](#35613)) ([feb5d00](feb5d00)) * conflicts ([2060a00](2060a00)) * CSS not applied to product title ([#35630](#35630)) ([2cf871c](2cf871c)) * don't set default payment amount in case of invoice return ([#35645](#35645)) ([79483cc](79483cc)) * Lower deduction certificate not getting applied ([#35667](#35667)) ([6f59fa9](6f59fa9)) * Make difference entry button not working ([#35622](#35622)) ([043815e](043815e)) * make showing taxes as table in print configurable (backport [#35672](#35672)) ([#35678](#35678)) ([f39ae9d](f39ae9d)) * Payment against credit notes will be considered as payment against parent invoice in Accounts Receivable/Payable report ([#35642](#35642)) ([81ef2ba](81ef2ba)) * Project in item-wise sales register ([#35596](#35596)) ([7737b90](7737b90)) * Stock Reconciliation document update while reposting ([8b617fb](8b617fb)) * test case ([7af0380](7af0380)) * Update de.csv ([#35278](#35278)) ([2077f6e](2077f6e)) * Validation for delivery date in Sales Order ([#35597](#35597)) ([4a8ce22](4a8ce22))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at status_updater.py, the logic for the opportunity to be converted is to create a Sales Order.
However, currently this status does not update, I create the sales order and the status of the opportunity remains as Quotation.
So to solve the problem, when updating the Quotation status, it already updates the Opportunity status.
On submit sales order set opportunity status to Converted, on Cancel set status to Quotation back.