Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tab-uniformity #35400

Merged
merged 2 commits into from
May 24, 2023
Merged

fix: tab-uniformity #35400

merged 2 commits into from
May 24, 2023

Conversation

GursheenK
Copy link
Member

@GursheenK GursheenK commented May 24, 2023 •
edited by s-aga-r
Loading

Changed the Purchase Order tab name to Connections to match that of other Doctypes including Purchase Invoice, Sales Invoice, Sales Order etc.

Enabled uniformity of Tabs in Doctypes.

Screenshots

Purchase Order
Screenshot 2023-05-24 at 11 49 00 AM

Purchase Invoice
Screenshot 2023-05-24 at 11 46 40 AM

Closes: #34072

@s-aga-r s-aga-r changed the title fix: tab-uniformity-#34072 fix: tab-uniformity May 24, 2023
@s-aga-r
Copy link
Contributor

s-aga-r commented May 24, 2023 •
edited
Loading

@GursheenK use semantic commit messages in future, docs

@s-aga-r s-aga-r added the backport version-14-hotfix backport to version 14 label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #35400 (b4b1bfe) into develop (3940deb) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #35400   +/-   ##
========================================
  Coverage    63.82%   63.82%           
========================================
  Files          813      813           
  Lines        60260    60260           
========================================
+ Hits         38460    38462    +2     
+ Misses       21800    21798    -2

see 2 files with indirect coverage changes

@s-aga-r s-aga-r merged commit c1f1a03 into frappe:develop May 24, 2023
9 of 10 checks passed
mergify bot pushed a commit that referenced this pull request May 24, 2023
@GursheenK @mergify
fix: tab-uniformity (#35400)
f64ee7b 
Made Doctype tabs uniform

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit c1f1a03)
@mergify mergify bot mentioned this pull request May 24, 2023
Merged
s-aga-r pushed a commit that referenced this pull request May 24, 2023
@mergify @GursheenK
fix: tab-uniformity (backport #35400) (#35402)
989052c 
fix: tab-uniformity (#35400)

Made Doctype tabs uniform

Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
(cherry picked from commit c1f1a03)

Co-authored-by: Gursheen Kaur Anand <40693548+GursheenK@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request May 31, 2023
@frappe-bot
chore(release): Bumped to Version 14.26.0
69b214b 
# [14.26.0](v14.25.1...v14.26.0) (2023-05-31)

### Bug Fixes

* account group totals calculation to consider include_in_gross ([8dcb930](8dcb930))
* add total col for gross and net profit ([cb9b4fb](cb9b4fb))
* available qty not fetching for raw material in PP ([746a734](746a734))
* balance quantity ([56ba7d6](56ba7d6))
* Billing Address display in buying transactions ([#35451](#35451)) ([33e8d05](33e8d05))
* don't map items twice ([6f0c7cf](6f0c7cf))
* Error while validating budget ([#35487](#35487)) ([5fd00e7](5fd00e7))
* **Gross Profit:** 'company' column is ambiguous in filter ([a59c205](a59c205))
* incorrect `POS Reserved Qty` in `Stock Projected Qty` Report ([71e4f34](71e4f34))
* incorrect available quantity in BIN ([5a9452f](5a9452f))
* incorrect transferred qty in the job card ([#35478](#35478)) ([86801c2](86801c2))
* make DN item reference mandatory for Packing Slip Item ([b4e481a](b4e481a))
* map `Packed Items` while creating `Packing Slip` ([984e32c](984e32c))
* monthly WDV depr schedule for existing assets [v14] ([#35458](#35458)) ([37d437a](37d437a))
* Negative value in Reserved Qty for Production Plan ([6fe42c9](6fe42c9))
* Packing Slip Item Qty ([5345ebe](5345ebe))
* **patch:** add patch to set `packed_qty` in draft DN ([b3da2f7](b3da2f7))
* rate not fetching properly for inter transfer purchase order ([7b75f45](7b75f45))
* remove duplicate items validation ([c7628c9](c7628c9))
* retention stock entry: grab conversion factor from source ([bd75584](bd75584))
* Show future payments in accounts receivable summary ([#35416](#35416)) ([11440cc](11440cc))
* Stock Analytics and Warehouse wise Item Balance Age and Value issue ([2058993](2058993))
* stock onboarding (backport [#35453](#35453)) ([#35480](#35480)) ([d231b19](d231b19))
* tab-uniformity (backport [#35400](#35400)) ([#35402](#35402)) ([989052c](989052c))
* travis ([fe1e2fe](fe1e2fe))
* update `Packed Qty` in DN on submit and cancel of `Packing Slip` ([0bed062](0bed062))
* **ux:** don't show `Create > Packing Slip` button if items are already packed ([9854c84](9854c84))
* **ux:** get items on selecting DN in Packing Slip ([b96aa75](b96aa75))
* **ux:** remove `Get Items` button from `Packing Slip` ([4017342](4017342))
* validate Packing Slip Item Qty with DN Items ([cc7e267](cc7e267))

### Features

* add field `Packed Qty` in `Delivery Note Item` and `Packed Item` ([509b684](509b684))
* add field `pi_detail` in `Packing Slip` ([2b75474](2b75474))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r s-aga-r approved these changes

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab uniformity: Dashboard Vs Connections
2 participants
@GursheenK @s-aga-r