Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gross and Net Profit Report - incorrect calculation of totals (backport #35320) #35418

Merged
merged 4 commits into from
May 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 25, 2023

This is an automatic backport of pull request #35320 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

(cherry picked from commit 50822f2)
rename function
remove return statement as the list is  mutated

(cherry picked from commit 1a3b9c5)
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #35418 (3f117b3) into develop (0bc9c32) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35418      +/-   ##
===========================================
- Coverage    63.77%   63.77%   -0.01%     
===========================================
  Files          814      814              
  Lines        60464    60468       +4     
===========================================
  Hits         38562    38562              
- Misses       21902    21906       +4     
Impacted Files Coverage Δ
...d_net_profit_report/gross_and_net_profit_report.py 0.00% <0.00%> (ø)

@deepeshgarg007 deepeshgarg007 merged commit 55806c5 into develop May 25, 2023
13 checks passed
@mergify mergify bot deleted the mergify/bp/develop/pr-35320 branch May 25, 2023 12:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants