refactor: Leave Application should not be in hook.py #36008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure this is correct, but AFAIK, Leave Application is in hrms app.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36008 +/- ##
========================================
Coverage 64.22% 64.22%
========================================
Files 785 785
Lines 60640 60640
========================================
Hits 38949 38949
Misses 21691 21691
|
|
@kittiu please also create a PR to https://github.com/frappe/hrms that adds this line there, so that we don't lose any functionality. |
Thanks and done. |
|
@kittiu Can you create the pull request on hrms? |
|
frappe/hrms#691 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit 2607847) # Conflicts: # erpnext/hooks.py
ruchamahabal
added a commit
that referenced
this pull request
Jul 18, 2023
#36158) Co-authored-by: Kitti U. @ Ecosoft <kittiu@gmail.com> Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure this is correct, but AFAIK, Leave Application should be in hrms app, is it not?