Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Batch Item Expiry Status report #36106

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Jul 12, 2023

Issues:

  • The Batch Item Expiry Status report retrieves data from the SLE, which causes the report to slow down when there is a large number of SLEs.
  • The Serial and Batch Bundle reference will be stored in SLEs from v15 instead of Batch No and Serial No.

Before:

image

After:

image

#32735

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 12, 2023
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Jul 12, 2023
@s-aga-r s-aga-r marked this pull request as ready for review July 12, 2023 12:42
@s-aga-r s-aga-r enabled auto-merge (squash) July 12, 2023 12:51
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #36106 (c3436f5) into develop (c16a581) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36106      +/-   ##
===========================================
+ Coverage    64.20%   64.21%   +0.01%     
===========================================
  Files          785      785              
  Lines        60703    60677      -26     
===========================================
- Hits         38975    38965      -10     
+ Misses       21728    21712      -16     
Impacted Files Coverage Δ
...ange_rate_revaluation/exchange_rate_revaluation.py 55.98% <0.00%> (ø)
erpnext/accounts/utils.py 73.70% <ø> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 80.41% <ø> (ø)
erpnext/stock/doctype/item/item.py 85.66% <0.00%> (ø)
erpnext/assets/doctype/asset/depreciation.py 81.31% <23.07%> (ø)
erpnext/controllers/stock_controller.py 82.49% <50.00%> (ø)
...xt/assets/doctype/asset_movement/asset_movement.py 77.61% <60.00%> (+4.75%) ⬆️
erpnext/controllers/buying_controller.py 84.66% <66.66%> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 83.31% <77.77%> (ø)
...tch_item_expiry_status/batch_item_expiry_status.py 82.14% <85.00%> (+15.47%) ⬆️
... and 3 more

@s-aga-r s-aga-r disabled auto-merge July 13, 2023 00:14
@s-aga-r s-aga-r merged commit 5f307f9 into frappe:develop Jul 13, 2023
15 checks passed
mergify bot pushed a commit that referenced this pull request Jul 13, 2023
s-aga-r added a commit that referenced this pull request Jul 15, 2023
refactor: `Batch Item Expiry Status` report (#36106)

(cherry picked from commit 5f307f9)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
@s-aga-r s-aga-r deleted the FIX-ISS-23-24-02007 branch July 27, 2023 08:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant