Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:show invoices name instead of object address #36298

Conversation

gouravsaini021
Copy link
Contributor

comma_and function in expecting a list but it gets a tuple so it is returning an object instead of a string so in message it also show object

Screenshot from 2023-07-25 14-35-48

after passing a list in comma_and function

Screenshot from 2023-07-25 14-36-38

comma_and function in expecting a list but it gets a tuple so it is returning a object instead of a string
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 25, 2023
@ruthra-kumar ruthra-kumar self-assigned this Jul 25, 2023
@ruthra-kumar ruthra-kumar merged commit 2e5c531 into frappe:version-14 Jul 25, 2023
9 of 10 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.32.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ruthra-kumar ruthra-kumar added backport develop instructs mergify to frontport PR to develop branch backport version-14-hotfix backport to version 14 labels Jul 26, 2023
ruthra-kumar added a commit that referenced this pull request Jul 26, 2023
…-36298

fix: show invoices name instead of object address (backport #36298)
ruthra-kumar added a commit that referenced this pull request Jul 26, 2023
fix: show invoices name instead of object address (backport #36298)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport develop instructs mergify to frontport PR to develop branch backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants