feat: utility to repost accounting ledgers without cancellation #36469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36469 +/- ##
===========================================
+ Coverage 64.61% 64.69% +0.08%
===========================================
Files 788 791 +3
Lines 61436 61572 +136
===========================================
+ Hits 39697 39837 +140
+ Misses 21739 21735 -4
|
ruthra-kumar
force-pushed
the
repost_accounting_ledger
branch
from
d272b41
to
157d946
Compare
ruthra-kumar
force-pushed
the
repost_accounting_ledger
branch
from
d419fc8
to
42b4a7e
Compare
|
Need to add validation to prevent reposting on Invoices with Deferred Revenue or Expense Edit: Added |
ruthra-kumar
force-pushed
the
repost_accounting_ledger
branch
from
c74038c
to
4c56043
Compare
mergify bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
* feat: introduce doctypes for repost * refactor: basic filters and validations * chore: basic validations * chore: added barebones function to generate ledger entries * chore: repost on submit * chore: repost in background * chore: include payment entry and journal entry * chore: ignore repost doc on cancel * chore: preview method * chore: rudimentary form of preview * refactor: preview template * refactor: basic background colors to differentiate old and new * chore: remove commented code * test: basic functionality * chore: fix conflict * chore: prevent repost on invoices with deferred accounting * refactor(test): rename and test basic validations and methods * refactor(test): test all validations * fix(test): use proper name account name * refactor(test): fix failing test case * refactor(test): clear old entries * refactor(test): simpler logic to clear old records * refactor(test): make use of deletion flag * refactor(test): split into multiple test cases (cherry picked from commit e64b004) # Conflicts: # erpnext/accounts/doctype/journal_entry/journal_entry.js
ruthra-kumar
added a commit
that referenced
this pull request
Aug 19, 2023
…-36469 feat: utility to repost accounting ledgers without cancellation (backport #36469)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
# [14.36.0](v14.35.2...v14.36.0) (2023-08-23) ### Bug Fixes * Accounts Payable Currency bug ([94612b9](94612b9)) * Add company filters for account ([e62ffa9](e62ffa9)) * add missing items labels back ([#36737](#36737)) ([3634e80](3634e80)) * broken advance field in Accounts Receivable summary rpt ([296a4d7](296a4d7)) * broken consolidated report due to finance book filter ([5bd2a09](5bd2a09)) * check tax and charges if it is passed ([1f76c69](1f76c69)) * clear dimension defaults after test ([2a467a9](2a467a9)) * dict value for dimension for gl entries defined without the dimension ([11ba553](11ba553)) * dimension name in remark ([01ae513](01ae513)) * divide offsetting amount for multiple dimensions ([1269f2d](1269f2d)) * divide offsetting amount only when account exists ([2c8c3a0](2c8c3a0)) * Document Name link validation in Bank Reconciliation Tool ([#36495](#36495)) ([83cbc1b](83cbc1b)), closes [#35540](#35540) [#35540](#35540) * don't throw if item does not have default BOM (backport [#36709](#36709)) ([#36734](#36734)) ([e1bd9a7](e1bd9a7)) * duplicate acc dimension in test ([cdb66bf](cdb66bf)) * fetch acc dimensions correctly when fieldname is different from name ([7ac35b4](7ac35b4)) * fetch accounting dimension details specific to company ([c1f1a21](c1f1a21)) * include gain/loss journal in AR/AP reports ([4606079](4606079)) * incorrect gl balance on multi company setup ([cb9aad3](cb9aad3)) * incorrect schedule in asset value adjustment ([#36725](#36725)) ([a0575ed](a0575ed)) * make offsetting entry for acc dimensions ([3198f26](3198f26)) * make offsetting entry for all doctypes ([f578c32](f578c32)) * mode of payment fetched from pos profile company in POS ([c74a414](c74a414)) * not able to make stock entry ([#36759](#36759)) ([873ee38](873ee38)) * Procurement Tracker report not showing material request items ([#36768](#36768)) ([6a9935c](6a9935c)) * reset dimension defaults when company changedin test ([37ef6e9](37ef6e9)) * **RFQ:** make "update password" and "submit quotation" buttons the same size (backport [#36667](#36667)) ([#36686](#36686)) ([36147ec](36147ec)) * timeout error coming during reposting ([#36715](#36715)) ([620b21f](620b21f)) * **ux:** change batch selection message to alert (backport [#36500](#36500)) ([#36697](#36697)) ([0a4947a](0a4947a)) * **UX:** Ignore prepared report ([3e23e1f](3e23e1f)) ### Features * **RFQ:** make email message fully configurable (backport [#36353](#36353)) ([#36531](#36531)) ([c308bd5](c308bd5)) * Tick on checkbox to include draft timesheets (backport [#36577](#36577)) ([#36640](#36640)) ([9668615](9668615)) * utility to repost accounting ledgers without cancellation ([#36469](#36469)) ([f8d6fe6](f8d6fe6)) ### Performance Improvements * pull latest details only for referenced vouchers ([47345e8](47345e8))
|
@ruthra-kumar a test that was introduced here is consistently failing across unrelated PRs. For example:
Kindly have a look at this. |
|
@barredterra |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a utility doctype
Repost Accounting Ledger. This will repostGL EntryandPayment Ledger Entryfor source documents, without need for cancel and amending. Currently supports Sales Invoice, Purchase Invoice, Payment Entry and Journal Entry.Show Previewgives the list of old and the new entries that will be created.This utility will be backported along with Exchange Gain/Loss booking refactor
no-docs