-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create entries for only PR items present in LCV #36852
Merged
deepeshgarg007
merged 2 commits into
frappe:develop
from
GursheenK:lcv-gle-for-only-chosen-items
Aug 29, 2023
Merged
fix: create entries for only PR items present in LCV #36852
deepeshgarg007
merged 2 commits into
frappe:develop
from
GursheenK:lcv-gle-for-only-chosen-items
Aug 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #36852 +/- ##
========================================
Coverage 65.42% 65.42%
========================================
Files 794 794
Lines 62172 62181 +9
========================================
+ Hits 40673 40681 +8
- Misses 21499 21500 +1
|
deepeshgarg007
approved these changes
Aug 29, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2023
* fix: check if item code exists in lcv before creating gle * refactor: use qb to fetch lcv items (cherry picked from commit 26e8b8f)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
# [14.37.0](v14.36.0...v14.37.0) (2023-08-30) ### Bug Fixes * added valuation field type (Float/Currency) in the filter (backport [#36866](#36866)) ([#36868](#36868)) ([22247cf](22247cf)) * Allow to make return against sales invoice which has closed sales order ([0f98cc8](0f98cc8)) * Asset Category filter is not working in asset depreciation([#36806](#36806)) ([bd41cb2](bd41cb2)) * create entries for only PR items present in LCV ([#36852](#36852)) ([d2091cc](d2091cc)) * error in report when data is not available to load chart in report (backport [#36842](#36842)) ([#36853](#36853)) ([9789b7b](9789b7b)) * error listindexoutofrange when save a production plan ([#36807](#36807)) ([fd41594](fd41594)) * fetch JVs in tax withholding report without party values ([bc6bd81](bc6bd81)) * fetch rounded total while pulling reference details on SO ([adc87f1](adc87f1)) * missing company flag for regional fn ([#36791](#36791)) ([c07548a](c07548a)) * SCR return status (backport [#36793](#36793)) ([#36796](#36796)) ([6edfcf4](6edfcf4)) * Tax withholding reversal on Debit Notes ([e8dc63c](e8dc63c)) ### Features * **MR:** Project and Cost Center in Connections (backport [#36794](#36794)) ([#36795](#36795)) ([4fa0777](4fa0777))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
KeyError is thrown while submitting LCV for a Purchase Invoice where items do not match.
Steps to replicate bug
Screenshot
Fix
Added check to ensure GL entries are made only for items present in the LCV.
no-docs