Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precision issue and column name (backport #37073) #37089

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 14, 2023

This is an automatic backport of pull request #37073 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #37089 (6d53ca8) into develop (2dbdc40) will increase coverage by 0.00%.
Report is 32 commits behind head on develop.
The diff coverage is 67.64%.

@@            Coverage Diff            @@
##           develop   #37089    +/-   ##
=========================================
  Coverage    66.49%   66.49%            
=========================================
  Files          791      793     +2     
  Lines        62315    62433   +118     
=========================================
+ Hits         41436    41517    +81     
- Misses       20879    20916    +37     
Files Changed Coverage
...xt/accounts/doctype/payment_entry/payment_entry.py ø
...xt/accounts/doctype/sales_invoice/sales_invoice.py ø
...nd_receive/requested_items_to_order_and_receive.py 33.33%
erpnext/controllers/accounts_controller.py 33.33%
...ctype/unreconcile_payments/unreconcile_payments.py 55.73%
erpnext/accounts/utils.py 97.91%
...ile_payment_entries/unreconcile_payment_entries.py 100.00%

@rohitwaghchaure rohitwaghchaure merged commit 08aaf22 into develop Sep 15, 2023
13 of 14 checks passed
@mergify mergify bot deleted the mergify/bp/develop/pr-37073 branch September 15, 2023 06:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant