Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stock Ledger Variance report #37165

Merged
merged 2 commits into from
Sep 21, 2023
Merged

feat: Stock Ledger Variance report #37165

merged 2 commits into from
Sep 21, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Sep 20, 2023 •
edited
Loading

image

This report concise the process of identifying discrepancies in Qty, Value, and Valuation, it uses the Stock Ledger Invariant Check report under the hood. Its purpose is to efficiently pinpoint the initial point of difference for all Item and Warehouse combinations.

Why?
The Stock Ledger Invariant Check report necessitates specifying the Item and Warehouse to retrieve the data, followed by the steps of identifying the initial discrepancies. Then navigate to Repost Item Valuation to rectify the discrepancy, which can become time-consuming when there are n numbers of Item and Warehouse combinations.

Key Benefits:

  • Provides a consolidated view of all discrepancies in Qty, Value, and Valuation on a single page.
  • Displays only the initial entries where discrepancies started, eliminating the need to sift through all the entries.
  • Allow creation of Repost Item Valuation entries directly from the report.

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #37165 (08d357d) into develop (08d91ab) will increase coverage by 0.11%.
Report is 39 commits behind head on develop.
The diff coverage is 53.56%.

@@             Coverage Diff             @@
##           develop   #37165      +/-   ##
===========================================
+ Coverage    66.58%   66.70%   +0.11%     
===========================================
  Files          793      794       +1     
  Lines        62496    62479      -17     
===========================================
+ Hits         41616    41679      +63     
+ Misses       20880    20800      -80
Files Changed Coverage
...next/accounts/doctype/ledger_merge/ledger_merge.py ø
...ctype/process_subscription/process_subscription.py 0.00%
...e_purchase_register/item_wise_purchase_register.py ø
erpnext/accounts/test/accounts_mixin.py ø
erpnext/e_commerce/product_data_engine/query.py 0.00%
erpnext/hooks.py ø
erpnext/stock/dashboard/item_dashboard.py ø
...ort/stock_ledger_variance/stock_ledger_variance.py 0.00%
erpnext/templates/pages/wishlist.py 0.00%
...er_invariant_check/stock_ledger_invariant_check.py 18.75%
... and 19 more

@rohitwaghchaure
Copy link
Collaborator

@s-aga-r Can you show the same columns which are there in the report Stock Ledger Invariant Check

@s-aga-r s-aga-r marked this pull request as ready for review September 21, 2023 07:21
@s-aga-r s-aga-r merged commit acda72d into frappe:develop Sep 21, 2023
13 checks passed
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Sep 21, 2023
mergify bot pushed a commit that referenced this pull request Sep 21, 2023
@s-aga-r @mergify
feat: Stock Ledger Variance report (#37165)
ac8029d 
* feat: `Stock Ledger Variance` report

* refactor: `get_data()`

(cherry picked from commit acda72d)
mergify bot pushed a commit that referenced this pull request Sep 21, 2023
@s-aga-r @mergify
feat: Stock Ledger Variance report (#37165)
1a4d365 
* feat: `Stock Ledger Variance` report

* refactor: `get_data()`

(cherry picked from commit acda72d)
This was referenced Sep 21, 2023
Merged
Merged
s-aga-r added a commit that referenced this pull request Sep 21, 2023
@mergify @s-aga-r
feat: Stock Ledger Variance report (backport #37165) (#37183)
02fc67c 
feat: `Stock Ledger Variance` report (#37165)

* feat: `Stock Ledger Variance` report

* refactor: `get_data()`

(cherry picked from commit acda72d)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
s-aga-r added a commit that referenced this pull request Sep 21, 2023
@mergify @s-aga-r
feat: Stock Ledger Variance report (backport #37165) (#37184)
5092ea1 
feat: `Stock Ledger Variance` report (#37165)

* feat: `Stock Ledger Variance` report

* refactor: `get_data()`

(cherry picked from commit acda72d)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
deepeshgarg007 pushed a commit that referenced this pull request Sep 27, 2023
@frappe-pr-bot @mergify
@rohitwaghchaure @s-aga-r @marination @ruthra-kumar
chore: release v13 (#37245)
4285bbc 
* feat: provision to make reposting entries from Stock and Account Value Comparison Report (backport #35365) (#37171)

* feat: provision to make reposting entries from Stock and Account Value Comparison Report

(cherry picked from commit 7b818e9)

* fix: `linter`

* fix(ux): throw if no row selected to create repost entries

---------

Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>

* fix: incorrect stock ledger entries in DN (backport #36944) (#37067)

* fix: incorrect stock ledger entries in DN (#36944)

(cherry picked from commit 0e83190)

# Conflicts:
#	erpnext/stock/doctype/delivery_note/delivery_note.json

* chore: fix conflicts

---------

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>

* feat: `Stock Ledger Variance` report (backport #37165) (#37184)

feat: `Stock Ledger Variance` report (#37165)

* feat: `Stock Ledger Variance` report

* refactor: `get_data()`

(cherry picked from commit acda72d)

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>

* fix: Update `advance_paid` in SO/PO after unlinking from advance entry

(cherry picked from commit 426350e)

* test: Impact on SO of advance PE submit and unlinking/replacement by SI

(cherry picked from commit 8a4954d)

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
Co-authored-by: marination <maricadsouza221197@gmail.com>
Co-authored-by: ruthra kumar <ruthra@erpnext.com>
frappe-pr-bot pushed a commit that referenced this pull request Sep 27, 2023
@frappe-bot
chore(release): Bumped to Version 14.41.0
abb6044 
# [14.41.0](v14.40.0...v14.41.0) (2023-09-27)

### Bug Fixes

* allow to select parent warehouse in the website item (backport [#37047](#37047)) ([#37173](#37173)) ([56657b6](56657b6))
* AP & AR summary filters to match AR  (backport [#37248](#37248)) ([#37261](#37261)) ([1dc58b3](1dc58b3))
* apply gl report filters ([b4bc44d](b4bc44d))
* german translation of Sales and Purchase Invoice ([#37122](#37122)) ([8236814](8236814))
* incorrect `Parent Task` getting set for 2nd to nth child Task (backport [#37230](#37230)) ([#37240](#37240)) ([279f21d](279f21d))
* labels for `Stock Ledger Invariant Check` report (backport [#37150](#37150)) ([#37176](#37176)) ([f2bcfb5](f2bcfb5))
* **Material Request:** consider project for item details (backport [#37215](#37215)) ([#37221](#37221)) ([25f800d](25f800d))
* reserved qty for production plan ([#37251](#37251)) ([0a0d5b3](0a0d5b3))
* serial number decimal issue ([#37242](#37242)) ([78ab201](78ab201))
* set customer currency in pos_invoice if exists ([e0da8d2](e0da8d2))
* Update `advance_paid` in SO/PO after unlinking from advance entry ([1181dcf](1181dcf))
* validate duplicate serial no on submit in DN ([#37243](#37243)) ([70e2093](70e2093))

### Features

* `Stock Ledger Variance` report (backport [#37165](#37165)) ([#37183](#37183)) ([02fc67c](02fc67c))
* Toggle net values in Trial Balance report ([57c82c1](57c82c1))
frappe-pr-bot pushed a commit that referenced this pull request Oct 4, 2023
@frappe-bot
chore(release): Bumped to Version 13.54.0
b0708d2 
# [13.54.0](v13.53.0...v13.54.0) (2023-10-04)

### Bug Fixes

* incorrect stock ledger entries in DN (backport [#36944](#36944)) ([#37067](#37067)) ([5833c4d](5833c4d))
* trial balance report freezes when adding filters (backport [#37264](#37264)) ([#37267](#37267)) ([ff6b38c](ff6b38c))
* Update `advance_paid` in SO/PO after unlinking from advance entry ([a6bef64](a6bef64))

### Features

* `Stock Ledger Variance` report (backport [#37165](#37165)) ([#37184](#37184)) ([5092ea1](5092ea1))
* provision to make reposting entries from Stock and Account Value Comparison Report (backport [#35365](#35365)) ([#37171](#37171)) ([48eb6a6](48eb6a6))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@s-aga-r @rohitwaghchaure