fix: GL Entries not getting created for PR Return #37513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-aga-r
added a commit
that referenced
this pull request
Oct 15, 2023
…37516) * fix: GL Entries not getting created for PR Return (cherry picked from commit 46add06) * test: add test case for PR return with zero rate (cherry picked from commit 253d478) # Conflicts: # erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py * chore: `conflicts` --------- Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
## [14.44.1](v14.44.0...v14.44.1) (2023-10-19) ### Bug Fixes * billed_qty to show a sum of all invoiced qty from the purchase order item. (backport [#37539](#37539)) ([#37558](#37558)) ([ac7d6d6](ac7d6d6)) * consider received qty while creating SO -> MR (backport [#37414](#37414)) ([#37514](#37514)) ([1b94510](1b94510)) * don't set finance books if gross_purchase_amount is not set (backport [#37480](#37480)) ([#37482](#37482)) ([0590f21](0590f21)) * e-commerce permissions for address ([#37554](#37554)) ([022f85d](022f85d)) * german tranlations of "Is Return" ([f9b2355](f9b2355)) * GL Entries not getting created for PR Return (backport [#37513](#37513)) ([#37516](#37516)) ([c32258e](c32258e)) * **gp:** wrong `allocated_amount` on multi sales person invoice ([d266423](d266423)) * Incorrect vat amount in KSA VAT report ([44f7de0](44f7de0)) * inflated total amt in TDS report using back calculation ([78e22af](78e22af)) * Issues related to RFQ and Supplier Quotation on Portal (backport [#37565](#37565)) ([#37577](#37577)) ([e1504ef](e1504ef)) * keep customer/supplier website role by default ([76ef61c](76ef61c)) * keyerror on gl and pl comparision report ([6f143d3](6f143d3)) * payment entry count on supplier dashboard (backport [#37571](#37571)) ([#37575](#37575)) ([95abd79](95abd79)) * same Serial No get mapped while creating SO -> DN ([#37527](#37527)) ([5025850](5025850)) * serial and batch no get removed on save of return DN ([#37476](#37476)) ([f1814a1](f1814a1)) * Stock Reconciliation Insufficient Stock Error ([#37494](#37494)) ([9406ddb](9406ddb)) * **test:** project test case (backport [#37541](#37541)) ([#37543](#37543)) ([e23710b](e23710b)) * use `flt` to ignore TypeError ([#37481](#37481)) ([d2b22db](d2b22db)) ### Performance Improvements * index `dn_detail` in `Delivery Note Item` (backport [#37528](#37528)) ([#37530](#37530)) ([001c230](001c230))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source / Ref: 4388
Issue: Accounting Entries (GL Entries) not getting created for Purchase Return with 0 Rate, creating a difference between stock and account.
Steps to Reproduce:
Typically, the return rate matches the purchase rate. For instance, let's consider an example where the Valuation Method is set to Moving Average. The current Purchase Rate is 0, and the Moving Average is 50. When you initiate a Purchase Return, the rate will remain at 0. This action will result in a stock adjustment of -250 units (calculated as -5 * 50), and no GL Entries will be generated which will create a difference of 250.
Purchase Receipt:
Purchase Return:
Before:
After: