Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: utility to debug financial reports - Bisect Accounting Statements #38496

Merged
merged 31 commits into from
Dec 27, 2023

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Dec 1, 2023

A tool to debug any difference in 'Balance Sheet' and 'Profit and Loss' Statements. The tool first builds a binary search tree for the give time frame and then allows user to interactively navigate the tree left, right or up, runs the Balance Sheet and Profit & Loss reports for that section and shows the difference between them. The heatmap is just for better visualization.

bisect_converted.mp4

no-docs

Copy link

stale bot commented Dec 17, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Dec 17, 2023
@stale stale bot closed this Dec 21, 2023
@ruthra-kumar ruthra-kumar reopened this Dec 27, 2023
@stale stale bot removed the inactive label Dec 27, 2023
@ruthra-kumar ruthra-kumar marked this pull request as ready for review December 27, 2023 11:35
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 4316 lines in your changes are missing coverage. Please review.

Comparison is base (961bdf0) 60.15% compared to head (0890b41) 60.05%.
Report is 282 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38496      +/-   ##
===========================================
- Coverage    60.15%   60.05%   -0.11%     
===========================================
  Files          760      761       +1     
  Lines        69470    70096     +626     
===========================================
+ Hits         41791    42097     +306     
- Misses       27679    27999     +320     
Files Coverage Δ
..._receivable_summary/accounts_receivable_summary.py 92.23% <100.00%> (ø)
...ext/accounts/report/balance_sheet/balance_sheet.py 85.58% <100.00%> (ø)
...unts/report/purchase_register/purchase_register.py 86.33% <100.00%> (ø)
erpnext/accounts/utils.py 73.82% <ø> (+0.03%) ⬆️
erpnext/controllers/buying_controller.py 83.94% <100.00%> (ø)
erpnext/controllers/sales_and_purchase_return.py 90.60% <100.00%> (+3.34%) ⬆️
erpnext/controllers/subcontracting_controller.py 89.38% <100.00%> (-0.18%) ⬇️
erpnext/hooks.py 100.00% <100.00%> (ø)
erpnext/__init__.py 70.00% <0.00%> (ø)
...t/accounts/report/sales_register/sales_register.py 70.35% <50.00%> (ø)
... and 259 more

... and 48 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 12560e2 into frappe:develop Dec 27, 2023
13 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
@barredterra
Copy link
Collaborator

@ruthra-kumar could you add some basic docs, so people can understand and use this feature?

@ruthra-kumar
Copy link
Member Author

@ruthra-kumar could you add some basic docs, so people can understand and use this feature?

This is essentially a tool to speed up debugging an issue. So, i've refrained from adding docs to it.

I've updated the Pull Request description with some details though.

@barredterra
Copy link
Collaborator

Thank you!

@ruthra-kumar ruthra-kumar changed the title feat: utility to debug financial reports feat: utility to debug financial reports - Bisect Accounting Statements Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants