-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add login user to driver if available for notifications #39638
feat: add login user to driver if available for notifications #39638
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #39638 +/- ##
===========================================
- Coverage 60.76% 60.13% -0.64%
===========================================
Files 760 758 -2
Lines 71881 70955 -926
===========================================
- Hits 43682 42669 -1013
- Misses 28199 28286 +87
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
Any example of an Internal User specific data? |
Yes, in our case it's Matrix ID (for matrix chat). But it could be email, phone or pager, too. I should also note, that not every driver is also an employee. Hence, if employee isn't set, then the user field can be set freely. However, any driver that should be incorporated into the company's notification infrastructure can be required, if not an employee, to be(come) a user. Thus external service providers, indeed are users so they get notifications, itinerary, maps links, etc via Matrix Chat. |
Maybe I should also add, that in our deployment, this works together with: frappe/frappe#24725 That PR implements the selection of a user field as a notification target. |
Looks like a simple addition. Once the Framework changes are merged, then we can merge this as well. |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
@ruthra-kumar can you maybe help recommend the framework changes with a trusted colleague responsible for the framework? It would be nice if we where to avoid the endless and nasty stale bot loop on this one. Thx, that'd be much appreciated! |
ping |
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
@ruthra-kumar Could you please help to push for frappe/frappe#24725 Thanks! |
ping |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
Kindly help move this PR forward. Many thanks from Yours Sincerely! |
@ruthra-kumar fyi, the framework changes have just been merged. |
Use Case
Proposed Solution
no-docs