chore: switch to ruff for python formatting/linting #40681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akhilnarang can you look into this too. Lets move ERPNext and later HRMS too to same config. There are some improvements over flake8 (like that variable checking rule!) |
barredterra
requested review from
deepeshgarg007,
rohitwaghchaure,
s-aga-r and
ruthra-kumar
as code owners
akhilnarang
force-pushed
the
ruff
branch
9 times, most recently
from
918280a
to
e7b7da1
Compare
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Fixup some tests for py312 Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This was referenced Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to ruff, in order to stay consistent with the framework. It's a replacement for black, isort and flake8.
Todo (after approval): bulk-format all files (
ruff format .) and add commit to.git-ignore-revs.