Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correcting balance sheet calculation for zero liabilities and equity #41497

Merged
merged 2 commits into from
Jun 3, 2024
Merged

fix: correcting balance sheet calculation for zero liabilities and equity #41497

merged 2 commits into from
Jun 3, 2024

Conversation

Nihantra-Patel
Copy link
Contributor

version 15

fixes: #41488 and https://discuss.frappe.io/t/provisional-profit-loss-credit-shows-0-despite-total-asset-value-in-balance-sheet-report/123335

Before:

  • In the Balance Sheet report, if the Total Liability and Total Equity are both zero, the Provisional Profit/Loss (Credit) is not calculated.

image

After:

image

image

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 16, 2024
@stale stale bot added the inactive label Jun 2, 2024
@frappe frappe deleted a comment from stale bot Jun 2, 2024
@stale stale bot removed the inactive label Jun 2, 2024
@nabinhait nabinhait merged commit 3c33135 into frappe:develop Jun 3, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Jun 3, 2024
@Nihantra-Patel @mergify
fix: correcting balance sheet calculation for zero liabilities and eq…
2104d90 
…uity (#41497)

* fix: correcting balance sheet calculation for zero liabilities and equity

* fix: correcting balance sheet calculation for zero liabilities and equity

(cherry picked from commit 3c33135)

# Conflicts:
#	erpnext/accounts/report/balance_sheet/balance_sheet.py
@mergify mergify bot mentioned this pull request Jun 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabinhait nabinhait nabinhait approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
2 participants
@Nihantra-Patel @nabinhait