[UX] Error in purchase transaction - Ignore instead of Prompt #7766 #9295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
added a commit
that referenced
this pull request
Jun 16, 2017
rmehta
reviewed
Jun 16, 2017
| frappe.throw(_("Tax Category can not be 'Valuation' or 'Valuation and Total' as all items are non-stock items")) | ||
| for d in tax_for_valuation: | ||
| d.db_set("category", 'Total') | ||
| msgprint("Tax Category has been changed to \"Total\" because all Items in the Purchase Order " |
There was a problem hiding this comment.
all messages have to be translatable _("Tax ...")
Also translatable messages cannot be broken into separate lines, and you cannot escape \ inside translatable messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7766
If all items are non-stock items, the tax category is changed to 'Total' and a message is displayed on the page to notify the user of the change.
Before
AFter