Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Error in purchase transaction - Ignore instead of Prompt #7766 #9329

Merged
merged 3 commits into from
Jun 16, 2017

Conversation

tundebabzy
Copy link
Contributor

Corrections from #9295.
Reference issue (#7766)

Notice is now translatable and no longer multi-line

@tundebabzy tundebabzy requested a review from rmehta June 16, 2017 09:01
@mbauskar
Copy link
Contributor

@tundebabzy ,

Previous PR was reverted #9320

Closing this PR for now

@mbauskar mbauskar closed this Jun 16, 2017
@rmehta rmehta reopened this Jun 16, 2017
@rmehta
Copy link
Member

rmehta commented Jun 16, 2017

@tundebabzy we don't use db_set in validate, because validate is called before saving (insert/update).

@frappe-pr-bot
Copy link
Collaborator

Pull Request Summary

Image or animted GIF Not Added

Please add an image or animated GIF as proof that you have manually tested this contribution. Hint: use LiceCAP to capture animated GIFs.

Test Case Not Added / Updated

Since you have changed a Python file, you must update the relevant python test case. If there is no test coverage for this code, then please add it.


Result

  • Passed: Small Pull Request

This summary was automatically generated based on this script

@rmehta rmehta merged commit 9a34620 into frappe:develop Jun 16, 2017
@tundebabzy tundebabzy deleted the issue-7766-1 branch June 21, 2017 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants