Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove order_by from linked document checks (backport #19229) #19242

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2022

This is an automatic backport of pull request #19229 done by Mergify.
Cherry-pick of 0259068 has failed:

On branch mergify/bp/version-13-hotfix/pr-19229
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit 025906840d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/desk/form/linked_with.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested review from a team and shariquerik and removed request for a team December 12, 2022 10:11
@mergify mergify bot added the conflicts label Dec 12, 2022
@mergify mergify bot assigned ankush Dec 12, 2022
@ankush ankush force-pushed the mergify/bp/version-13-hotfix/pr-19229 branch from 680b3fa to 9044cb5 Compare December 12, 2022 10:19
@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #19242 (0259068) into version-13-hotfix (425e4bf) will increase coverage by 0.58%.
The diff coverage is 69.06%.

❗ Current head 0259068 differs from pull request most recent head 9044cb5. Consider uploading reports for the commit 9044cb5 to get more accurate results

Additional details and impacted files
@@                  Coverage Diff                  @@
##           version-13-hotfix   #19242      +/-   ##
=====================================================
+ Coverage              63.91%   64.50%   +0.58%     
=====================================================
  Files                    750      754       +4     
  Lines                  68329    70027    +1698     
  Branches                6018     6115      +97     
=====================================================
+ Hits                   43670    45168    +1498     
- Misses                 21254    21364     +110     
- Partials                3405     3495      +90     
Flag Coverage Δ
server 68.43% <73.55%> (?)
server-ui 31.72% <23.55%> (+0.05%) ⬆️
ui-tests 51.22% <60.11%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit c2cde0c into version-13-hotfix Dec 12, 2022
@mergify mergify bot deleted the mergify/bp/version-13-hotfix/pr-19229 branch December 12, 2022 10:58
frappe-pr-bot pushed a commit that referenced this pull request Dec 13, 2022
# [13.46.0](v13.45.3...v13.46.0) (2022-12-13)

### Bug Fixes

* attribute error on export of reports with additional columns ([#19105](#19105)) ([#19119](#19119)) ([da28290](da28290))
* do not rename select field options and values on doctype rename ([#19223](#19223)) ([#19225](#19225)) ([47f5fd0](47f5fd0))
* **docshare:** return None if share_name and value are None ([#19187](#19187)) ([#19188](#19188)) ([4e2620a](4e2620a))
* log unknown usernames too for failed attempts ([#19199](#19199)) ([#19200](#19200)) ([a75fa10](a75fa10))
* only make fetch_from field read only if no input (backport [#19192](#19192)) ([#19194](#19194)) ([994c1ed](994c1ed))
* reload shared dialog upon checking any perm (backport [#19196](#19196)) ([#19197](#19197)) ([fd44b34](fd44b34))
* set-config -g ([#19217](#19217)) ([#19218](#19218)) ([458707e](458707e))
* stabilize shared with dialog (backport [#19170](#19170)) ([#19185](#19185)) ([4f9d755](4f9d755))
* unscrub and translate field names in tooltip explaining fetch from (backport [#19143](#19143)) ([#19173](#19173)) ([fc430d1](fc430d1))
* **UX:** forget password shows error on wrong email ([#19235](#19235)) ([#19239](#19239)) ([5257ca7](5257ca7))
* workflow icon not visible in mobile view ([dcb3933](dcb3933))

### Features

* allow user to pick all columns ([#19236](#19236)) ([927b264](927b264))
* finer frappe Recorder control with decorator (backport [#19220](#19220)) ([#19221](#19221)) ([3b18e7e](3b18e7e))
* inter-process file locks ([#19133](#19133)) ([#19145](#19145)) ([b34e8ce](b34e8ce))

### Performance Improvements

* remove order_by from linked_with checks ([#19229](#19229)) ([#19242](#19242)) ([c2cde0c](c2cde0c))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.46.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants