Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v14 - Only default Letter head printing on PDF #19515

Closed
fkalpana opened this issue Jan 7, 2023 · 0 comments · Fixed by #19627
Closed

v14 - Only default Letter head printing on PDF #19515

fkalpana opened this issue Jan 7, 2023 · 0 comments · Fixed by #19627
Assignees
@surajshetty3416
Labels
bug

Comments

@fkalpana
Copy link

fkalpana commented Jan 7, 2023

erpnext 14.12.0
frappe 14.21.1
hrms 1.0.0
payments 0.0.1

v14 - Only default Letterhead printing on PDF, regarless of the ltterhead user selected. Normal printing works flawlessly.
If no default letterhead is selected, the letterhead does not appear at all on PDF.

Tested with many doctypes, including sales invoice, quotation, leads etc. Same issue everywhere. ALso tested on multiple instances

wkhtmltopdf version is 0.12.6. and tested on Ubuntu 20+ and 22+

Please check
@fkalpana fkalpana added the bug label Jan 7, 2023
@dj12djdjs dj12djdjs mentioned this issue Jan 8, 2023
Closed
@surajshetty3416 surajshetty3416 mentioned this issue Jan 17, 2023
Merged
surajshetty3416 added a commit that referenced this issue Jan 17, 2023
@surajshetty3416
fix: Argument name should be letterhead instead of letter_head (#19627)
bc13f90 
fixes #19515
mergify bot pushed a commit that referenced this issue Jan 17, 2023
@surajshetty3416 @mergify
fix: Argument name should be letterhead instead of letter_head (#19627)
6c1d4c4 
fixes #19515

(cherry picked from commit bc13f90)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@surajshetty3416 surajshetty3416

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Argument name should be letterhead instead of letter_head surajshetty3416/frappe
3 participants
@surajshetty3416 @shariquerik @fkalpana