-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow internal links in Documentation URL #23020
Comments
I think this applies to all URL fields and attaching a URL as a file |
This can be relaxed for doc links for sure. Don't see a point in validating this aggressively, it can just be a warning instead of error. |
Relative URLs should be a configuration option. On some sites / pages / in some fields you might want to enforce absolute URLs. For a couple of reasons, including security and integrity, the latter case seems even more important. |
also closes frappe#23020
* feat: System Health Report (cherry picked from commit e06901a) * feat: background worker monitoring (cherry picked from commit d410af7) * feat: better bench doctor in UI (cherry picked from commit d7a0ed8) * feat: socketio health check (cherry picked from commit 023297b) # Conflicts: # realtime/handlers/frappe_handlers.js * feat: email health checks (cherry picked from commit 2df9e2e) * feat: Errors in System Health (cherry picked from commit 7bfa31f) * feat: database health stats (cherry picked from commit b9ed8c5) * feat: cache health (cherry picked from commit 92dc5f3) * feat: backup health (cherry picked from commit 614857e) * feat: system health - users (cherry picked from commit 5b70060) * refactor: Single page instead of tabs (cherry picked from commit 99d2dea) * feat: background jobs test (cherry picked from commit 7411c4f) * fix: exception handling for health report (cherry picked from commit cbf4351) * chore: rename child doctypes (cherry picked from commit a94534a) * feat: highlight bad indicators (cherry picked from commit 4f406d7) * fix(UX): help links and relative URLs also closes #23020 (cherry picked from commit d40b2a2) * feat: extend highlight to child tables (cherry picked from commit b0ce404) * refactor: use table for errors (cherry picked from commit 9154e42) * feat: failng scheduled jobs (cherry picked from commit c712780) * refactor: misc - fix styles - hardcode perm check - few more indicators - cache directory size for 5 min (rapid refreshes should be fast enough) (cherry picked from commit c9a8cd6) * chore: conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
* feat: System Health Report (cherry picked from commit e06901a) * feat: background worker monitoring (cherry picked from commit d410af7) * feat: better bench doctor in UI (cherry picked from commit d7a0ed8) * feat: socketio health check (cherry picked from commit 023297b) # Conflicts: # realtime/handlers.js * feat: email health checks (cherry picked from commit 2df9e2e) * feat: Errors in System Health (cherry picked from commit 7bfa31f) * feat: database health stats (cherry picked from commit b9ed8c5) * feat: cache health (cherry picked from commit 92dc5f3) * feat: backup health (cherry picked from commit 614857e) * feat: system health - users (cherry picked from commit 5b70060) * refactor: Single page instead of tabs (cherry picked from commit 99d2dea) * feat: background jobs test (cherry picked from commit 7411c4f) * fix: exception handling for health report (cherry picked from commit cbf4351) * chore: rename child doctypes (cherry picked from commit a94534a) * feat: highlight bad indicators (cherry picked from commit 4f406d7) * fix(UX): help links and relative URLs also closes #23020 (cherry picked from commit d40b2a2) * feat: extend highlight to child tables (cherry picked from commit b0ce404) * refactor: use table for errors (cherry picked from commit 9154e42) * feat: failng scheduled jobs (cherry picked from commit c712780) * refactor: misc - fix styles - hardcode perm check - few more indicators - cache directory size for 5 min (rapid refreshes should be fast enough) (cherry picked from commit c9a8cd6) * chore: v14 compat * chore: strip types * chore: v14 compat * chore: v14 compat * fix: redis cache isn't required --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
I'd like to be able to not hardcode hostname as current site domain could change anytime in the future. However, adding a link like
/docs/some-page
- essentially anything without a hostname throws a "Not a valid URL" error andThe text was updated successfully, but these errors were encountered: