Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: System Health Report (backport #26046) #26085

Merged
merged 21 commits into from
Apr 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 22, 2024

Screenshot speaks louder than words.

Screen Shot 2024-04-19 at 17 13 16-fullpage

TODO:

  • perf / caching ( removed most slow funcs, should load fine in <30 seconds in most cases, can make separate small requests in future if required)
  • error handling
  • tabs -> section (less clicking around)
  • highlight "bad" indicators
  • constantly failing scheduled jobs (can reveal things like broken backup, repost etc)
  • highlight error with >10 occurrences

Closes #25486


This is an automatic backport of pull request #26046 done by Mergify.

(cherry picked from commit e06901a)
(cherry picked from commit d410af7)
(cherry picked from commit d7a0ed8)
(cherry picked from commit 023297b)

# Conflicts:
#	realtime/handlers/frappe_handlers.js
(cherry picked from commit 2df9e2e)
(cherry picked from commit 7bfa31f)
(cherry picked from commit b9ed8c5)
(cherry picked from commit 92dc5f3)
(cherry picked from commit 614857e)
(cherry picked from commit 5b70060)
(cherry picked from commit 7411c4f)
(cherry picked from commit a94534a)
(cherry picked from commit 4f406d7)
also closes #23020

(cherry picked from commit d40b2a2)
(cherry picked from commit 9154e42)
(cherry picked from commit c712780)
- fix styles
- hardcode perm check
- few more indicators
- cache directory size for 5 min (rapid refreshes should be fast enough)

(cherry picked from commit c9a8cd6)
@mergify mergify bot requested a review from a team April 22, 2024 07:20
@mergify mergify bot added the conflicts label Apr 22, 2024
@mergify mergify bot requested review from ankush and removed request for a team April 22, 2024 07:20
@mergify mergify bot assigned ankush Apr 22, 2024
Copy link
Contributor Author

mergify bot commented Apr 22, 2024

Cherry-pick of 023297b has failed:

On branch mergify/bp/version-15-hotfix/pr-26046
Your branch is ahead of 'origin/version-15-hotfix' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 023297b52d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/desk/doctype/system_health_report/system_health_report.js
	modified:   frappe/desk/doctype/system_health_report/system_health_report.json
	modified:   frappe/desk/doctype/system_health_report/system_health_report.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   realtime/handlers/frappe_handlers.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@ankush ankush removed the conflicts label Apr 22, 2024
@ankush ankush enabled auto-merge (squash) April 22, 2024 07:41
@ankush ankush merged commit 7b8a923 into version-15-hotfix Apr 22, 2024
15 of 18 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-26046 branch April 22, 2024 11:12
frappe-pr-bot pushed a commit that referenced this pull request Apr 23, 2024
# [15.24.0](v15.23.0...v15.24.0) (2024-04-23)

### Bug Fixes

* 🐛 don't create __init__.py files when gathering pages ([#26045](#26045)) ([#26091](#26091)) ([285a30f](285a30f)), closes [#25167](#25167)
* allow setting dynamic filters for number cards even without developer mode ([8811e82](8811e82))
* Avoid permission check on unsaved doc ([#26027](#26027)) ([#26031](#26031)) ([334d353](334d353))
* dashboard link number color for timeless night ([#26058](#26058)) ([d6a060d](d6a060d))
* datepicker time row color for timeless night ([#26077](#26077)) ([ef2f3e2](ef2f3e2))
* filter select perm in get_doctypes_with_read (backport [#26037](#26037)) ([#26040](#26040)) ([2d7d38e](2d7d38e))
* filters on prepared report export ([627a0ed](627a0ed))
* **grid_row:** check child table dependent properties whenever a row is selected ([6ec64a8](6ec64a8))
* **grid:** ensure that `doc` itself is not null ([b4c9d40](b4c9d40)), closes [#25800](#25800)
* increase report limit ([#26102](#26102)) ([#26104](#26104)) ([8706dd8](8706dd8))
* limit select user to desk users by default ([#25843](#25843)) ([#25996](#25996)) ([374c75c](374c75c))
* only notify for modified greater than DB ([#26070](#26070)) ([#26071](#26071)) ([224d8aa](224d8aa))
* register faulthandler on true stderr only (backport [#26028](#26028)) ([#26034](#26034)) ([bb0f1be](bb0f1be))
* **report_view:** allow exporting all rows even if count is disabled ([0f65a23](0f65a23))
* **resolver:** handle werkzeug redirect exception ([3f9b5f3](3f9b5f3))
* runtime error during pot build ([#25991](#25991)) ([#25992](#25992)) ([58a133b](58a133b))
* strip redirect URIs for trailing whitespaces ([#26006](#26006)) ([#26008](#26008)) ([d543dd3](d543dd3))
* unknown charset windows-874 problem on incoming mail ([14e1a31](14e1a31))

### Features

* add copy to clipboard on read only code fields ([62f09f7](62f09f7))
* enable dynamic filters for standard number cards ([ba2f70a](ba2f70a))
* gettext translations (v15 port) ([#25982](#25982)) ([0189bb2](0189bb2))
* System Health Report (backport [#26046](#26046)) ([#26085](#26085)) ([7b8a923](7b8a923))
* What's New ([#25986](#25986)) ([fc0ab40](fc0ab40))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants