Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache github release data per bench (backport #26382) #26387

Merged
merged 2 commits into from
May 9, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 9, 2024

Reduce API calls to github as public calls are limited.

Speeds up #26314


This is an automatic backport of pull request #26382 done by [Mergify](https://mergify.com).

Reduce API calls to github as public calls are limited.

(cherry picked from commit c2d5ef1)

# Conflicts:
#	frappe/utils/caching.py
@mergify mergify bot requested a review from a team as a code owner May 9, 2024 06:54
@mergify mergify bot added the conflicts label May 9, 2024
@mergify mergify bot requested review from ankush and removed request for a team May 9, 2024 06:54
@mergify mergify bot assigned ankush May 9, 2024
Copy link
Contributor Author

mergify bot commented May 9, 2024

Cherry-pick of c2d5ef1 has failed:

On branch mergify/bp/version-15-hotfix/pr-26382
Your branch is up to date with 'origin/version-15-hotfix'.

You are currently cherry-picking commit c2d5ef175c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   frappe/utils/change_log.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   frappe/utils/caching.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 9, 2024
@ankush ankush enabled auto-merge (squash) May 9, 2024 07:02
@ankush ankush merged commit 6e8ef85 into version-15-hotfix May 9, 2024
17 checks passed
@ankush ankush deleted the mergify/bp/version-15-hotfix/pr-26382 branch May 9, 2024 07:20
frappe-pr-bot pushed a commit that referenced this pull request May 14, 2024
# [15.27.0](v15.26.0...v15.27.0) (2024-05-14)

### Bug Fixes

* allow navigating to `Table MultiSelect` fields using tab ([496ae05](496ae05))
* cache github release data per bench (backport [#26382](#26382)) ([#26387](#26387)) ([6e8ef85](6e8ef85))
* **document_follow:** `following` was treated as a string not a boolean ([e0ecfc6](e0ecfc6))
* Increase folder link field size ([#26381](#26381)) ([#26384](#26384)) ([52c335c](52c335c))
* **integrations:** add back `response.raise_for_status()` ([13182e4](13182e4))
* make rename_doc work pre_model_sync ([#26419](#26419)) ([2db51ea](2db51ea))
* pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26404](#26404)) ([a0eb7c1](a0eb7c1))

### Features

* functionality to assign users by user group ([#26044](#26044)) ([#26432](#26432)) ([c308931](c308931))

### Performance Improvements

* Don't update session in cache after every request ([#26308](#26308)) ([#26362](#26362)) ([c0ba12c](c0ba12c))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 15.27.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement conflicts released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants