perf: Don't update session in cache after every request #26308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
a team and
akhilnarang
and removed request for
a team
ankush
added
the
defer backport
github-actions
bot
added
the
add-test-cases
|
lol, this is only way it was ever put into cache. |
ankush
commented
May 3, 2024
It's just reading and writing same information except last_update inside data which is never read back from this.
These are all repeat get_docs which occur in common requests.
ankush
added
backport version-15-hotfix
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
It's just reading and writing same information except last_update inside data which is never read back from this. (cherry picked from commit 7fe9cc4) # Conflicts: # frappe/sessions.py
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2024
It's just reading and writing same information except last_update inside data which is never read back from this. (cherry picked from commit 7fe9cc4)
ankush
added a commit
that referenced
this pull request
May 9, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 14, 2024
# [15.27.0](v15.26.0...v15.27.0) (2024-05-14) ### Bug Fixes * allow navigating to `Table MultiSelect` fields using tab ([496ae05](496ae05)) * cache github release data per bench (backport [#26382](#26382)) ([#26387](#26387)) ([6e8ef85](6e8ef85)) * **document_follow:** `following` was treated as a string not a boolean ([e0ecfc6](e0ecfc6)) * Increase folder link field size ([#26381](#26381)) ([#26384](#26384)) ([52c335c](52c335c)) * **integrations:** add back `response.raise_for_status()` ([13182e4](13182e4)) * make rename_doc work pre_model_sync ([#26419](#26419)) ([2db51ea](2db51ea)) * pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26404](#26404)) ([a0eb7c1](a0eb7c1)) ### Features * functionality to assign users by user group ([#26044](#26044)) ([#26432](#26432)) ([c308931](c308931)) ### Performance Improvements * Don't update session in cache after every request ([#26308](#26308)) ([#26362](#26362)) ([c0ba12c](c0ba12c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just reading and writing same information except last_update inside data which is never read back from this.