-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Increase folder link field size #26381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it.
Highlight field by making it bold.
ankush
requested review from
a team and
akhilnarang
and removed request for
a team
May 9, 2024 06:20
github-actions
bot
added
the
add-test-cases
Add test case to validate fix or enhancement
label
May 9, 2024
ankush
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
Backport the PR to v15
labels
May 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2024
* fix: increase folder length to 255 File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it. * fix(UX): slightly better character len message Highlight field by making it bold. (cherry picked from commit 5351763) # Conflicts: # frappe/core/doctype/file/file.json # frappe/model/base_document.py
mergify bot
pushed a commit
that referenced
this pull request
May 9, 2024
* fix: increase folder length to 255 File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it. * fix(UX): slightly better character len message Highlight field by making it bold. (cherry picked from commit 5351763) # Conflicts: # frappe/core/doctype/file/file.json
This was referenced May 9, 2024
ankush
added a commit
that referenced
this pull request
May 9, 2024
* fix: increase folder length to 255 File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it. * fix(UX): slightly better character len message Highlight field by making it bold. (cherry picked from commit 5351763) # Conflicts: # frappe/core/doctype/file/file.json Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush
added a commit
that referenced
this pull request
May 9, 2024
* fix: increase folder length to 255 File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it. * fix(UX): slightly better character len message Highlight field by making it bold. (cherry picked from commit 5351763) # Conflicts: # frappe/core/doctype/file/file.json # frappe/model/base_document.py Co-authored-by: Ankush Menat <ankush@frappe.io>
rutwikhdev
pushed a commit
to rutwikhdev/frappe
that referenced
this pull request
May 11, 2024
* fix: increase folder length to 255 File `name` is 255 because it's bootstrapped using mariadb.sql, so users can create 255 char long folders but can't store anything in it. * fix(UX): slightly better character len message Highlight field by making it bold.
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 14, 2024
## [14.74.1](v14.74.0...v14.74.1) (2024-05-14) ### Bug Fixes * allow navigating to `Table MultiSelect` fields using tab ([1e5faff](1e5faff)) * **document_follow:** `following` was treated as a string not a boolean ([bdc48ad](bdc48ad)) * german translations ([#26370](#26370)) ([167e4e6](167e4e6)) * Increase folder link field size ([#26381](#26381)) ([#26383](#26383)) ([30db235](30db235)) * **integrations:** add back `response.raise_for_status()` ([dcf191c](dcf191c)) * make rename_doc work pre_model_sync ([#26419](#26419)) ([0d631ce](0d631ce))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 14, 2024
# [15.27.0](v15.26.0...v15.27.0) (2024-05-14) ### Bug Fixes * allow navigating to `Table MultiSelect` fields using tab ([496ae05](496ae05)) * cache github release data per bench (backport [#26382](#26382)) ([#26387](#26387)) ([6e8ef85](6e8ef85)) * **document_follow:** `following` was treated as a string not a boolean ([e0ecfc6](e0ecfc6)) * Increase folder link field size ([#26381](#26381)) ([#26384](#26384)) ([52c335c](52c335c)) * **integrations:** add back `response.raise_for_status()` ([13182e4](13182e4)) * make rename_doc work pre_model_sync ([#26419](#26419)) ([2db51ea](2db51ea)) * pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26404](#26404)) ([a0eb7c1](a0eb7c1)) ### Features * functionality to assign users by user group ([#26044](#26044)) ([#26432](#26432)) ([c308931](c308931)) ### Performance Improvements * Don't update session in cache after every request ([#26308](#26308)) ([#26362](#26362)) ([c0ba12c](c0ba12c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
add-test-cases
Add test case to validate fix or enhancement
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
Backport the PR to v15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File
name
is 255 because it's bootstrapped using mariadb.sql, so userscan create 255 char long folders but can't store anything in it.