Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix excel export #11933

Conversation

surajshetty3416
Copy link
Member

  • The system used to export an empty excel file while trying to export the report with a custom column.

Before:
report-export-fix

After:
report-export-fix-2

  • Now, column sizes in .xlsx file will be set based on column sizes of report columns.

port-of: #11642

@surajshetty3416 surajshetty3416 merged commit ccec3f3 into frappe:version-12-hotfix Nov 17, 2020
@surajshetty3416 surajshetty3416 deleted the fix-report-excel-export-version-12-hotfix branch November 17, 2020 13:28
@surajshetty3416
Copy link
Member Author

@Mergifyio backport v12-pre-release

mergify bot pushed a commit that referenced this pull request Nov 17, 2020
Co-authored-by: Prssanna Desai <prssud@gmail.com>
(cherry picked from commit ccec3f3)
@mergify
Copy link
Contributor

mergify bot commented Nov 17, 2020

Command backport v12-pre-release: success

Backports have been created

surajshetty3416 added a commit that referenced this pull request Nov 17, 2020
Co-authored-by: Prssanna Desai <prssud@gmail.com>
(cherry picked from commit ccec3f3)

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant