fix: Issue sending email with attachement (that are not added by sending users) (fix in version-12 but not in version-13) #17293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FHenry
force-pushed
the
version-13-fix_17052
branch
from
fbd04b4
to
bf62372
Compare
FHenry
changed the title
RJPvT
approved these changes
Jun 25, 2022
|
@surajshetty3416 Could you have a look please ? |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 5, 2022
# [13.35.0](v13.34.0...v13.35.0) (2022-07-05) ### Bug Fixes * "You viewed/edited/created this" (backport [#17365](#17365)) ([#17402](#17402)) ([3f90b51](3f90b51)) * calendar view set in assign time ([6303a4e](6303a4e)) * don't try appending email to sent folder if enable incoming and imap is turned off ([#17344](#17344)) ([eba2a99](eba2a99)) * don't try appending email to sent folder if enable incoming and imap is turned off ([#17344](#17344)) ([524f9f2](524f9f2)) * email not sent if contain file with current site url (backport [#17250](#17250)) ([#17330](#17330)) ([32a5a6f](32a5a6f)) * enable further translations (backport [#17323](#17323)) ([#17340](#17340)) ([c8a58d4](c8a58d4)) * encode docname when routing ([c8777c5](c8777c5)) * extra notification triggered on value change (backport [#17364](#17364)) ([#17366](#17366)) ([eaf82dd](eaf82dd)) * german translations (backport [#17324](#17324)) ([#17341](#17341)) ([bd702ca](bd702ca)) * Issue sending email with attachement (that are not added by sending users) (fix in version-12 but not in version-13) ([#17293](#17293)) ([e44d4d9](e44d4d9)) * make language, source, translation mandatory (backport [#17396](#17396)) ([#17397](#17397)) ([652e9ef](652e9ef)) * **migrate:** Set touched_tables flag prior to try block ([b4d2d31](b4d2d31)) * **redis:** pass shared param when setting value based on generator (backport [#17322](#17322)) ([#17328](#17328)) ([410066c](410066c)) * refresh tree when the treeview is loaded (backport [#17383](#17383)) ([#17401](#17401)) ([e2ef990](e2ef990)) * remove bare exceptions ([48d87bc](48d87bc)) * remove duplicate tracebacks (backport [#17385](#17385)) ([#17387](#17387)) ([bf91c91](bf91c91)) * remove spaces from email placeholders ([e427f51](e427f51)) * Replace new usages of placeholders ([c1f3e3f](c1f3e3f)) * Resolve conflicts ([dfec295](dfec295)) * Retain value in the field instance when field is rendered on a dialog w/o doc ([aa737bb](aa737bb)) * shortcut widget title overflowing ([#17399](#17399)) ([dff02cf](dff02cf)) * Skip invalid field in get_print_settings_to_show ([4beb66f](4beb66f)) * Translate strings in public folders too ([af9e402](af9e402)) * update ru translations ([#17404](#17404)) ([561fc51](561fc51)) * Use 'email_open_check' in template ([2237a17](2237a17)) ### Features * add email retry limit in system settings (backport [#17259](#17259)) ([#17336](#17336)) ([a87f156](a87f156))
|
🎉 This PR is included in version 13.35.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #17052 in version-13 as the PR #17053 was merge into version-12-hotfix, but as there is no "upport" fixes and the develop branch code do not have this bug (I didn't test it yet, but the code is way too different)