Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shortcut widget title overflowing #17399

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Jul 4, 2022

Before:
image

After:
image

Also added a title attribute on the widget title
image

@shariquerik shariquerik requested review from a team and phot0n and removed request for a team July 4, 2022 13:09
@shariquerik
Copy link
Member Author

Failing test fixed by #17403

@shariquerik shariquerik merged commit dff02cf into frappe:version-13-hotfix Jul 4, 2022
@shariquerik shariquerik deleted the shortcut-widget-overflowing-title branch July 4, 2022 14:59
frappe-pr-bot pushed a commit that referenced this pull request Jul 5, 2022
# [13.35.0](v13.34.0...v13.35.0) (2022-07-05)

### Bug Fixes

* "You viewed/edited/created this" (backport [#17365](#17365)) ([#17402](#17402)) ([3f90b51](3f90b51))
* calendar view set in assign time ([6303a4e](6303a4e))
* don't try appending email to sent folder if enable incoming and imap is turned off ([#17344](#17344)) ([eba2a99](eba2a99))
* don't try appending email to sent folder if enable incoming and imap is turned off ([#17344](#17344)) ([524f9f2](524f9f2))
* email not sent if contain file with current site url (backport [#17250](#17250)) ([#17330](#17330)) ([32a5a6f](32a5a6f))
* enable further translations (backport [#17323](#17323)) ([#17340](#17340)) ([c8a58d4](c8a58d4))
* encode docname when routing ([c8777c5](c8777c5))
* extra notification triggered on value change (backport [#17364](#17364)) ([#17366](#17366)) ([eaf82dd](eaf82dd))
* german translations (backport [#17324](#17324)) ([#17341](#17341)) ([bd702ca](bd702ca))
* Issue sending email with attachement (that are not added by sending users) (fix in version-12 but not in version-13) ([#17293](#17293)) ([e44d4d9](e44d4d9))
* make language, source, translation mandatory (backport [#17396](#17396)) ([#17397](#17397)) ([652e9ef](652e9ef))
* **migrate:** Set touched_tables flag prior to try block ([b4d2d31](b4d2d31))
* **redis:** pass shared param when setting value based on generator (backport [#17322](#17322)) ([#17328](#17328)) ([410066c](410066c))
* refresh tree when the treeview is  loaded (backport [#17383](#17383)) ([#17401](#17401)) ([e2ef990](e2ef990))
* remove bare exceptions ([48d87bc](48d87bc))
* remove duplicate tracebacks (backport [#17385](#17385)) ([#17387](#17387)) ([bf91c91](bf91c91))
* remove spaces from email placeholders ([e427f51](e427f51))
* Replace new usages of placeholders ([c1f3e3f](c1f3e3f))
* Resolve conflicts ([dfec295](dfec295))
* Retain value in the field instance when field is rendered on a dialog w/o doc ([aa737bb](aa737bb))
* shortcut widget title overflowing ([#17399](#17399)) ([dff02cf](dff02cf))
* Skip invalid field in get_print_settings_to_show ([4beb66f](4beb66f))
* Translate strings in public folders too ([af9e402](af9e402))
* update ru translations ([#17404](#17404)) ([561fc51](561fc51))
* Use 'email_open_check' in template ([2237a17](2237a17))

### Features

* add email retry limit in system settings (backport [#17259](#17259)) ([#17336](#17336)) ([a87f156](a87f156))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants