fix: 'EmailServer' object has no attribute 'imap'

[skjbulcher]

This PR is intended to fix the following traceback:

Traceback (most recent call last):
  File "apps/frappe/frappe/email/queue.py", line 581, in send_one                        
    smtpserver.email_account.append_email_to_sent_folder(message)
  File "apps/frappe/frappe/email/doctype/email_account/email_account.py", line 834, in append_email_to_sent_folder
    if email_server.imap:                         
AttributeError: 'EmailServer' object has no attribute 'imap'

I have email partially set up on my server (which is experiencing the above traceback): I use a notifications email address for outgoing emails, but I don't have any incoming email address configured, and I don't use imap for anything.

[phot0n]

So this might've happened because we try to put outgoing mails in sent folder which we use when imap is configured for that email account.

this option might've been checked perhaps 👇 (?)

I think we should not show that option if incoming email and imap is not configured.

Plus I'm also surprised - as getting to that line meant that the incoming server connection was established - since you've said that there was no incoming email account configured 🤯

[skjbulcher]

since you've said that there was no incoming email account configured

That is correct. I did have an email account set up at one point for document linking, but it isn't working for reasons both related and unrelated to ERPNext, so I unchecked "Enable Incoming". The only other account I set up is the notifications account, and "Enable Incoming" is unchecked on that account as well.

this option might've been checked perhaps (?)

Hmm. That isn't checked, but "Create Contacts from Incoming Emails" is. Does that have something to do with it?

---

Does my patch make sense, or are you trying to keep the code from getting that far when incoming emails are disabled?

[phot0n]

"Create Contacts from Incoming Emails" is. Does that have something to do with it?

I don't think so.

are you trying to keep the code from getting that far when incoming emails are disabled?

You've read my mind 😅 - I would definately like that (makes more sense somehow - please also check that imap is also enabled)

if not (self.enable_incoming and self.use_imap):
    return

Probably this at start of append_email_to_sent_folder (?)

As if you trace where the append_email_to_sent_folder method is being called from - it's only called when that option (the scshot i sent earlier) is enabled (and the email has been successfully sent to atleast 1 recipient).

frappe/frappe/email/queue.py

Lines 565 to 566 in 9d394c1

	if smtpserver.append_emails_to_sent_folder and email_sent_to_any_recipient:
	smtpserver.email_account.append_email_to_sent_folder(message)

Though I'm very curious as to how the incoming connection was established and how that code was executed when that option ("append email to sent folder") is not checked 👀

[skjbulcher]

I think append_emails_to_sent_folder is getting set here:

frappe/frappe/email/smtp.py

Line 238 in 5940d7d

self.append_emails_to_sent_folder = self.email_account.append_emails_to_sent_folder

I believe the setting is based on the domain:

I do have "Append Emails to Sent Folder" set on the domain, and I think it's grabbing it from there. However, I feel like my settings all make sense - or am I missing something?

Unfortunately I don't have more time to investigate this today or possibly even next week.

[phot0n]

I think append_emails_to_sent_folder is getting set here:

ah, i was talking about the method append_email_to_sent_folder 😅 - they both have similar name so it's a bit confusing

I do have "Append Emails to Sent Folder" set on the domain, and I think it's grabbing it from there. However, I feel like my settings all make sense - or am I missing something?

I think this might be the case - that does solve 1 mystery 🤣

I'll push a fix for this. Thanks!!

[frappe-pr-bot]

🎉 This PR is included in version 13.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀