fix: make role info translatable #20813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barredterra
requested review from
a team and
shariquerik
and removed request for
a team
barredterra
added
backport version-13-hotfix
backport version-14-hotfix
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #20813 +/- ##
========================================
Coverage 63.87% 63.87%
========================================
Files 759 759
Lines 68788 68786 -2
Branches 6221 6221
========================================
+ Hits 43937 43940 +3
+ Misses 21288 21283 -5
Partials 3563 3563
Flags with carried forward coverage won't be shown. Click here to find out more. |
surajshetty3416
approved these changes
Apr 24, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit e384d94) # Conflicts: # frappe/public/js/frappe/roles_editor.js
mergify bot
pushed a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit e384d94)
surajshetty3416
pushed a commit
that referenced
this pull request
Apr 24, 2023
surajshetty3416
added a commit
that referenced
this pull request
Apr 24, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
# [14.34.0](v14.33.1...v14.34.0) (2023-04-25) ### Bug Fixes * allow url type shortcut ([dbdf945](dbdf945)) * charts on dashboard not loading ([66ebda6](66ebda6)) * clear cache on delete of prop setters ([c798d7f](c798d7f)) * correctly return session usertype ([#20787](#20787)) ([#20789](#20789)) ([e7d8f47](e7d8f47)) * do not show section if it contains only hidden workspaces ([714fec0](714fec0)) * float formatting ([6b76017](6b76017)) * handle `SMTPRecipientsRefused` retries ([#20819](#20819)) ([#20827](#20827)) ([a2637c3](a2637c3)), closes [/github.com//pull/20819#discussion_r1175166987](https://github.com//github.com/frappe/frappe/pull/20819/issues/discussion_r1175166987) * letterhead not working for multiple doc print ([f40d060](f40d060)) * make role info translatable (backport [#20813](#20813)) ([#20829](#20829)) ([d8411cb](d8411cb)) * **patch:** only run disable_email_accounts_with_oauth if connected user is not set ([#20799](#20799)) ([#20801](#20801)) ([705f5a0](705f5a0)) * reload website settings to avoid chat module failure ([#20465](#20465)) ([#20766](#20766)) ([5f2e8fc](5f2e8fc)), closes [#2019-09-23](#2019) [#2020-10-17](#2020) [#2020-08-28](#2020) [#2020-08-25](#2020) * undefined link if no value for url data field in grid ([727b6d5](727b6d5)) * update deprecated deep selector syntax ([#20807](#20807)) ([#20811](#20811)) ([b5c5ec6](b5c5ec6)) * validate route conflict with new title if title is changed ([47bed47](47bed47)) * validate url string ([087613e](087613e)) ### Features * added URL type in workspace shortcut ([72ac481](72ac481)) * get anonymous response from webform ([db6f2f1](db6f2f1))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
# [13.56.0](v13.55.0...v13.56.0) (2023-04-25) ### Bug Fixes * charts on dashboard not loading ([a00405c](a00405c)) * clear cache on delete of prop setters ([7fac775](7fac775)) * format filter values in report print view (backport [#20717](#20717)) ([#20761](#20761)) ([6fc359f](6fc359f)) * make role info translatable (backport [#20813](#20813)) ([#20828](#20828)) ([265d9b2](265d9b2)) ### Features * email oauth (v13) ([#20790](#20790)) ([b4b6b66](b4b6b66))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (language set to german):
After (language set to german):
Responsiveness (scrolls on small screens instead of overflowing):
Bildschirmaufnahme.2023-04-21.um.17.20.59.mov