Merge from upstream v14 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix/pr-20798 feat: get anonymous response from webform (backport frappe#20798)
) `>>>` to `:deep` (cherry picked from commit 838919e) Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
) * fix: remove trailing and leading quotes from email * chore: typo * fix: dont retry `SMTPRecipientsRefused` If refused once it's unlikely to work again just by retrying. There's no mechanism to prevent infinite retry. This will still attempt for MAX_RETRY_COUNT. * Revert "fix: remove trailing and leading quotes from email" This reverts commit 2676ac2. refer frappe#20819 (comment) (cherry picked from commit eeda161) Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
…le by default (backport frappe#20823) (frappe#20834) Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
chore: release v14
# [14.34.0](frappe/frappe@v14.33.1...v14.34.0) (2023-04-25) ### Bug Fixes * allow url type shortcut ([dbdf945](frappe@dbdf945)) * charts on dashboard not loading ([66ebda6](frappe@66ebda6)) * clear cache on delete of prop setters ([c798d7f](frappe@c798d7f)) * correctly return session usertype ([frappe#20787](frappe#20787)) ([frappe#20789](frappe#20789)) ([e7d8f47](frappe@e7d8f47)) * do not show section if it contains only hidden workspaces ([714fec0](frappe@714fec0)) * float formatting ([6b76017](frappe@6b76017)) * handle `SMTPRecipientsRefused` retries ([frappe#20819](frappe#20819)) ([frappe#20827](frappe#20827)) ([a2637c3](frappe@a2637c3)), closes [/github.com/frappe/pull/20819#discussion_r1175166987](https://github.com//github.com/frappe/frappe/pull/20819/issues/discussion_r1175166987) * letterhead not working for multiple doc print ([f40d060](frappe@f40d060)) * make role info translatable (backport [frappe#20813](frappe#20813)) ([frappe#20829](frappe#20829)) ([d8411cb](frappe@d8411cb)) * **patch:** only run disable_email_accounts_with_oauth if connected user is not set ([frappe#20799](frappe#20799)) ([frappe#20801](frappe#20801)) ([705f5a0](frappe@705f5a0)) * reload website settings to avoid chat module failure ([frappe#20465](frappe#20465)) ([frappe#20766](frappe#20766)) ([5f2e8fc](frappe@5f2e8fc)), closes [frappe#2019-09-23](frappe#2019) [frappe#2020-10-17](frappe#2020) [frappe#2020-08-28](frappe#2020) [frappe#2020-08-25](frappe#2020) * undefined link if no value for url data field in grid ([727b6d5](frappe@727b6d5)) * update deprecated deep selector syntax ([frappe#20807](frappe#20807)) ([frappe#20811](frappe#20811)) ([b5c5ec6](frappe@b5c5ec6)) * validate route conflict with new title if title is changed ([47bed47](frappe@47bed47)) * validate url string ([087613e](frappe@087613e)) ### Features * added URL type in workspace shortcut ([72ac481](frappe@72ac481)) * get anonymous response from webform ([db6f2f1](frappe@db6f2f1))
…rappe#20843) frappe.call ensures that it's only passed to functions which can accept it, so nothing to worry about ~ backward compatible change. (cherry picked from commit 109a549) Co-authored-by: Ankush Menat <ankush@frappe.io>
If the option "Create Contacts from Incoming Emails" is enabled in the "Email Account" and if an incorrect address is specified by the sender of the letter, an error occurs:
"Unable to add contact"
.......
File "apps/frappe/frappe/__init__.py", line 442, in _raise_exception
raise raise_exception(msg)
inspect = <module 'inspect' from '/usr/lib/python3.10/inspect.py'>
msg = 'Jon Dark is not a valid Email Address'
raise_exception = <class 'frappe.exceptions.InvalidEmailAddressError'>
frappe.exceptions.InvalidEmailAddressError: Jon Dark is not a valid Email Address
…rappe#20575) (frappe#20847) Co-authored-by: Andrew McLeod <andrewclimbing@gmail.com>
…rappe#20868) Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
(cherry picked from commit 8418d3c)
…fix/pr-20871 fix: only call RQ synchronously as fallback during migration (backport frappe#20871)
chore: release v14
# [14.35.0](frappe/frappe@v14.34.0...v14.35.0) (2023-05-02) ### Bug Fixes * check for @ in email string in get_emails ([frappe#20759](frappe#20759)) ([961097f](frappe@961097f)) * multiple assignments to the same person (backport [frappe#20822](frappe#20822)) ([frappe#20868](frappe#20868)) ([07d29c3](frappe@07d29c3)) * only call RQ synchronously as fallback during migration ([dc01b48](frappe@dc01b48)) * pass parent document type for number card ([frappe#20857](frappe#20857)) ([frappe#20858](frappe#20858)) ([e1f4e5f](frappe@e1f4e5f)) * pass reference_doctype to search query methods ([frappe#20842](frappe#20842)) ([frappe#20843](frappe#20843)) ([f8ec758](frappe@f8ec758)) * removed footer ([88e23ea](frappe@88e23ea)) * removed logo implementation ([1ce79e3](frappe@1ce79e3)) * renamed login without password to passwordless login ([43b67ee](frappe@43b67ee)) * suggested changes and added passwordless_login_expiry option ([a19b1ce](frappe@a19b1ce)) * type checking ([ee49d4c](frappe@ee49d4c)) * typeerror while marking communication as read ([frappe#20830](frappe#20830)) ([1798c1c](frappe@1798c1c)) * **workflow:** add whitelisted functions permissions checks (backport [frappe#20575](frappe#20575)) ([frappe#20847](frappe#20847)) ([082fed5](frappe@082fed5)) ### Features * Login without password (through link sent on email) ([d87345a](frappe@d87345a))
…port frappe#20711) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> Co-authored-by: Leonard Goertz <49870752+uepselon@users.noreply.github.com>
* fix: use after_insert hook for enqueuing report generation this removes the need of additionally calling enqueue_report method * enqueue report in long queue * reduce the timeout from 100 mins to 30 mins (cherry picked from commit 9bfc43c) * refactor: remove unnecessary fields from prepared report * removed ref_report_doctype * changed title_field from ref_report_doctype to report_name (both are same) * changed report_name field to link type * changed autonaming to hash based * added status in list view via document states (cherry picked from commit 4fe8ead) # Conflicts: # frappe/desk/query_report.py * feat(minor): add job_id column to prepared report * chore: make report_name mandatory (cherry picked from commit ecbafb5) * fix(ux): don't show report_name field on prepared report doc (cherry picked from commit cd468c3) * refactor(minor): dry-er code in generate_report (cherry picked from commit 6218a99) * refactor: cleanup peprared result render and old logs cleanup * directly fetch columns from result file rather than storing it in db * remove prepared report settings from system settings * remove disable_prepared_report from report doctype (cherry picked from commit 18d48dd) # Conflicts: # frappe/core/doctype/log_settings/log_settings.py # frappe/desk/query_report.py * chore: add queued_by virual docfield in prepared report (cherry picked from commit 433615b) * perf: use modified for fetching old logs for clearing (cherry picked from commit 08bae70) * refactor(minor): use virtual docfield for report_start_time - and renamed it to queued_at * chore: rename Report End Time label to Finished At (cherry picked from commit 917dfda) * fix: dont show filters when not present in prepared report (cherry picked from commit eea2fd9) * fix: get_prepared_data - add with_file_name param for returning filename of the attachment (cherry picked from commit 0d275b6) * fix: use doc.get to check if columns field exists or not (cherry picked from commit bf132ab) * feat(minor): option to show charts, total_row with prepared reports (cherry picked from commit a69c82e) # Conflicts: # frappe/desk/query_report.py * chore: patches for copying disable_prepared_report and removing prepared report settings from system settings (cherry picked from commit 0370c80) # Conflicts: # frappe/patches.txt * test: prepared report tests * fix: update job_id for prepared report (cherry picked from commit 246caea) * fix: render filters on refresh onload hook gave inconsistent behaviour (cherry picked from commit c8ea0a7) * refactor(minor): disable_prepared_report -> enable_prepared_report for role permission for page and report (cherry picked from commit 1a50194) # Conflicts: # frappe/core/doctype/role_permission_for_page_and_report/role_permission_for_page_and_report.json * chore: convert job_id to link fieldtype in prepared report doctype (cherry picked from commit f88d76f) * chore: use default timeout 25 mins for prepared report (cherry picked from commit 5444df7) * fix: check read permission when downloading prepared report file (cherry picked from commit 8c28a23) * refactor: remove breakages from report and role perm for pages and report * chore: resolve conflicts * chore: remove unnecessary patch * fix(patch); move removal of prepared report settings from system settings to post model sync * chore: disable tracking changes & use background_enqueue_run for generating prepared report * chore: fix linter --------- Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
(cherry picked from commit 155465c) Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit d60acc7)
…frappe#21301) * perf: use cached workflow doc for transitions (frappe#21300) * fix: expire `RECORDER_INTERCEPT_FLAG` in one hour Leaving this running in prod can be dangerous. * perf: Use cached doc in workflows (cherry picked from commit 774a75d) # Conflicts: # frappe/recorder.py * conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
…(backport frappe#21275) (frappe#21299) Co-authored-by: Vimal Patel <vimal@vimal-macpro.home> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> closes frappe#21250
(cherry picked from commit e86df2e)
(cherry picked from commit b9d4974)
(cherry picked from commit 895dab8)
…rappe#21258) (frappe#21325) (cherry picked from commit 3446ca9) Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
## [14.38.1](frappe/frappe@v14.38.0...v14.38.1) (2023-06-12) ### Bug Fixes * consider default value for content in update_workspace2 patch ([frappe#21258](frappe#21258)) ([frappe#21325](frappe#21325)) ([f657d29](frappe@f657d29))
…21295 fix: currency precision formatter (backport frappe#21293)
## [14.38.2](frappe/frappe@v14.38.1...v14.38.2) (2023-06-12) ### Bug Fixes * currency precision formatter ([frappe#21293](frappe#21293)) ([frappe#21295](frappe#21295)) ([e4d99ba](frappe@e4d99ba))
…fix/pr-19433 fix: allow video files to be uploaded (backport frappe#19433)
…appe#21329) * fix: virtual fields in child tables * Update frappe/model/base_document.py Co-authored-by: Ankush Menat <ankushmenat@gmail.com> * fix: virtual fields in child tables not displaying --------- Co-authored-by: Ankush Menat <ankushmenat@gmail.com> (cherry picked from commit 090c91b) Co-authored-by: Vincent Vrithof <98533401+vvrithof@users.noreply.github.com>
…rappe#21315) * build(deps): bump cryptography and pyOpenSSL (frappe#21307) cryptography to 41.0.1, pyOpenSSL to 23.2.0 (cherry picked from commit ed3b764) # Conflicts: # pyproject.toml * chore: resolve conflicts --------- Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
(cherry picked from commit 93c8c2d) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
(cherry picked from commit 93c8c2d) Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
## [14.38.3](frappe/frappe@v14.38.2...v14.38.3) (2023-06-12) ### Bug Fixes * error in workspace patch ([frappe#21335](frappe#21335)) ([0992c33](frappe@0992c33))
(cherry picked from commit f7abf3b)
(cherry picked from commit 1bab900)
…) (frappe#21352) * Fix: no role assigned message when role profile is passed * refactor: rename misleading method --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 9d20509) Co-authored-by: Vishal Kumar <vishnshiv3@gmail.com>
…fix/pr-21341 Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
chore: release v14
# [14.39.0](frappe/frappe@v14.38.3...v14.39.0) (2023-06-13) ### Bug Fixes * allow video files to be uploaded ([9c43e40](frappe@9c43e40)) * Clear hash once the scrolling is done ([c89a390](frappe@c89a390)) * consider default value for content in update_workspace2 patch ([frappe#21258](frappe#21258)) ([frappe#21286](frappe#21286)) ([fa7c114](frappe@fa7c114)) * currency precision formatter ([frappe#21293](frappe#21293)) ([frappe#21295](frappe#21295)) ([c5fa12d](frappe@c5fa12d)) * error in workspace patch ([frappe#21335](frappe#21335)) ([b452c63](frappe@b452c63)) * handle fixture syncing for missing doctypes ([cad99f1](frappe@cad99f1)) * improve delete_contact_and_address ([frappe#20381](frappe#20381)) ([frappe#21280](frappe#21280)) ([fcb614e](frappe@fcb614e)) * New Dashboard Chart throws TypeError: format requires a mapping (backport [frappe#21275](frappe#21275)) ([frappe#21299](frappe#21299)) ([0a5bec5](frappe@0a5bec5)), closes [frappe#21250](frappe#21250) * no role assigned message when role profile is passed ([frappe#21342](frappe#21342)) ([frappe#21352](frappe#21352)) ([e23503b](frappe@e23503b)) * Pass URL hash separately ([ef47548](frappe@ef47548)) * reuse redis connection if not rq auth ([frappe#21336](frappe#21336)) ([2748d9c](frappe@2748d9c)) * skip custom script syncing for missing doctypes ([12b8dac](frappe@12b8dac)) * sync importable doctype before documents ([frappe#21131](frappe#21131)) ([frappe#21327](frappe#21327)) ([0852b37](frappe@0852b37)) * virtual fields in child tables not displaying ([frappe#20528](frappe#20528)) ([frappe#21329](frappe#21329)) ([232f217](frappe@232f217)) ### Features * Scroll to field via URL ([604c4a3](frappe@604c4a3)) ### Performance Improvements * use cached workflow doc for transitions (backport [frappe#21300](frappe#21300)) ([frappe#21301](frappe#21301)) ([b6fb8a2](frappe@b6fb8a2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs: