Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check permission_type in get_permitted_fieldnames [v13] (backport #20905) #20955

Merged
merged 4 commits into from
May 16, 2023

Commits on May 10, 2023

  1. fix: Check permission_type in get_permitted_fieldnames [v14] (#20905)

    * fix: Dont assume user & permission_type in get_permitted_fileds
    
    * fix: Allow only search fields for select permission type
    
    * test: Add check for permitted fields with select perm
    
    * fix: Setup permission_map & use get_permitted_fields
    
    * fix: Pass current dt as fallback parent_doctype
    
    * fix(reportview): Use get_permitted_fields for resource API
    
    Added check for system setting `apply_perm_level_on_api_calls` on this
    change
    
    * test: Enable permlevel restrictions to test select query
    
    (cherry picked from commit 707e485)
    
    # Conflicts:
    #	frappe/desk/reportview.py
    #	frappe/model/__init__.py
    #	frappe/model/db_query.py
    #	frappe/tests/test_permissions.py
    gavindsouza authored and mergify[bot] committed May 10, 2023
    Configuration menu
    Copy the full SHA
    088931a View commit details
    Browse the repository at this point in the history
  2. fix: Resolve conflicts

    * Fixed imports
    * Compatible typing
    * Revert permission_map
    gavindsouza committed May 10, 2023
    Configuration menu
    Copy the full SHA
    43ce286 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. Configuration menu
    Copy the full SHA
    97f93be View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. Configuration menu
    Copy the full SHA
    87149b6 View commit details
    Browse the repository at this point in the history