fix: Check permission_type in get_permitted_fieldnames [v13] (backport #20905) #20955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix: Dont assume user & permission_type in get_permitted_fileds * fix: Allow only search fields for select permission type * test: Add check for permitted fields with select perm * fix: Setup permission_map & use get_permitted_fields * fix: Pass current dt as fallback parent_doctype * fix(reportview): Use get_permitted_fields for resource API Added check for system setting `apply_perm_level_on_api_calls` on this change * test: Enable permlevel restrictions to test select query (cherry picked from commit 707e485) # Conflicts: # frappe/desk/reportview.py # frappe/model/__init__.py # frappe/model/db_query.py # frappe/tests/test_permissions.py
gavindsouza
changed the title
* Fixed imports * Compatible typing * Revert permission_map
gavindsouza
force-pushed
the
mergify/bp/version-13-hotfix/pr-20905
branch
from
0d90797
to
43ce286
Compare
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 16, 2023
## [13.56.3](v13.56.2...v13.56.3) (2023-05-16) ### Bug Fixes * avoid internal arrays in get_all_docs (backport [#20950](#20950)) ([#20958](#20958)) ([43b051f](43b051f)) * Check permission_type in get_permitted_fieldnames [v13] (backport [#20905](#20905)) ([#20955](#20955)) ([ea6d350](ea6d350)) * don't use default filters for auto-email report ([#20876](#20876)) ([7d7500f](7d7500f)) * filters while exporting or creating new auto email reports for custom reports (backport [#20960](#20960)) ([#21020](#21020)) ([723ec9a](723ec9a)) * report print view not working ([#21002](#21002)) ([#21003](#21003)) ([ca73d72](ca73d72))
|
🎉 This PR is included in version 13.56.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a v13 backport of pull request #20905 via #20810.