fix: report print view not working (backport #21002) #21003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
```
report_view.js:1353 Uncaught TypeError: Cannot read properties of undefined (reading 'label')
at report_view.js:1353:31
at Array.map (<anonymous>)
at frappe.views.ReportView.get_filters_html_for_print (report_view.js:1349:5)
at report_view.js:1414:23
at print_utils.js:67:4
at frappe.ui.Dialog.<anonymous> (messages.js:104:4)
at HTMLButtonElement.<anonymous> (dialog.js:165:20)
at HTMLButtonElement.dispatch (jquery.js:5430:27)
at c1.handle (jquery.js:5234:28)
```
[skip ci]
(cherry picked from commit 73276a2)
ankush
force-pushed
the
mergify/bp/version-13-hotfix/pr-21002
branch
from
ecbe538
to
a37060f
Compare
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 16, 2023
## [13.56.3](v13.56.2...v13.56.3) (2023-05-16) ### Bug Fixes * avoid internal arrays in get_all_docs (backport [#20950](#20950)) ([#20958](#20958)) ([43b051f](43b051f)) * Check permission_type in get_permitted_fieldnames [v13] (backport [#20905](#20905)) ([#20955](#20955)) ([ea6d350](ea6d350)) * don't use default filters for auto-email report ([#20876](#20876)) ([7d7500f](7d7500f)) * filters while exporting or creating new auto email reports for custom reports (backport [#20960](#20960)) ([#21020](#21020)) ([723ec9a](723ec9a)) * report print view not working ([#21002](#21002)) ([#21003](#21003)) ([ca73d72](ca73d72))
|
🎉 This PR is included in version 13.56.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #21002 done by Mergify.
Cherry-pick of 73276a2 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com