fix: avoid internal arrays in get_all_docs #20950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariquerik
requested review from
a team and
phot0n
and removed request for
a team
shariquerik
added
backport version-13-hotfix
backport version-14-hotfix
This was referenced May 10, 2023
shariquerik
pushed a commit
that referenced
this pull request
May 10, 2023
shariquerik
pushed a commit
that referenced
this pull request
May 10, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 16, 2023
## [14.36.1](v14.36.0...v14.36.1) (2023-05-16) ### Bug Fixes * avoid internal arrays in get_all_docs (backport [#20950](#20950)) ([#20959](#20959)) ([44ea1a3](44ea1a3)) * call make_columns before update_order (backport [#20710](#20710)) ([#20964](#20964)) ([fb01789](fb01789)) * Check permission_type in get_permitted_fieldnames [v14] ([#20905](#20905)) ([707e485](707e485)) * colwidth should be acceptable ([58d0018](58d0018)) * do not consider time while formating date range value ([76f1b2c](76f1b2c)) * don't use default filters for auto-email report ([#20876](#20876)) ([1c97472](1c97472)) * email: get unsub email: use `cstr` instead of `encode` ([#20985](#20985)) ([f44bcf6](f44bcf6)) * filters while exporting or creating new auto email reports for custom reports (backport [#20960](#20960)) ([#21021](#21021)) ([4de6990](4de6990)) * limit RQ job refresh to list view only ([00215d7](00215d7)) * maintain frappe.router.current_router ([7c98b14](7c98b14)) * naming part should be empty if field is empty ([#20978](#20978)) ([#20982](#20982)) ([58a5a0f](58a5a0f)) * process filters for prepared_report while making and getting prepared report missed in ([#19565](#19565)) ([#20981](#20981)) ([b857eab](b857eab)) * Remove unnecessary request from boot ([e9dab33](e9dab33)) * remove unwanted imports ([6b350dd](6b350dd)) * report print view not working ([#21002](#21002)) ([#21004](#21004)) ([4028b5c](4028b5c)) * Request on "/login" instead of "/" ([337b149](337b149)) * Resolve conflicts ([11dfadc](11dfadc)) * unable to access url file from the timeline section ([#20836](#20836)) ([573c6ad](573c6ad)) * use sentinel value for checking existence of key in doc while parsing naming series ([#20994](#20994)) ([#20995](#20995)) ([785e52b](785e52b)) * **UX:** Show alert instead msgprint ([#21016](#21016)) ([#21017](#21017)) ([91f957b](91f957b)) * **UX:** sort modules on user doctype ([#20998](#20998)) ([#20999](#20999)) ([89c00d2](89c00d2)) * validate email on setup wizard (backport [#20979](#20979)) ([#20987](#20987)) ([3bcf450](3bcf450)), closes [#19601](#19601) ### Performance Improvements * Faster scheduled job deduplication (backport [#20937](#20937)) ([#20949](#20949)) ([60f118e](60f118e))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 16, 2023
## [13.56.3](v13.56.2...v13.56.3) (2023-05-16) ### Bug Fixes * avoid internal arrays in get_all_docs (backport [#20950](#20950)) ([#20958](#20958)) ([43b051f](43b051f)) * Check permission_type in get_permitted_fieldnames [v13] (backport [#20905](#20905)) ([#20955](#20955)) ([ea6d350](ea6d350)) * don't use default filters for auto-email report ([#20876](#20876)) ([7d7500f](7d7500f)) * filters while exporting or creating new auto email reports for custom reports (backport [#20960](#20960)) ([#21020](#21020)) ([723ec9a](723ec9a)) * report print view not working ([#21002](#21002)) ([#21003](#21003)) ([ca73d72](ca73d72))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When you create a new Purchase Order (It doesn't matter if you use Tab to add a new row just add a new row and delete it) then save
Will get an error (This is not an actual problem ignore this)
After resolving the above error Mandatory fields required in row 2 error pop up
It is happening because in erpnext
_itemsArray is getting created which is a duplicate ofitemsand while deleting the value from it is not removed