Commits on Aug 19, 2023

1. fix!: create property setters for system generated custom fields …

   (cherry picked from commit 43b5d95)

   

   sagarvora authored and mergify[bot] committed Aug 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 5bbfb1d
   • Browse repository at this point

   Copy the full SHA

   5bbfb1d View commit details

   Browse the repository at this point in the history

2. fix!: make system generated fields unsortable …

   (cherry picked from commit 9a88acf)

   

   sagarvora authored and mergify[bot] committed Aug 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 735600b
   • Browse repository at this point

   Copy the full SHA

   735600b View commit details

   Browse the repository at this point in the history

3. style: use const instead of let …

   (cherry picked from commit 1ed4b2d)

   

   sagarvora authored and mergify[bot] committed Aug 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 10e5a38
   • Browse repository at this point

   Copy the full SHA

   10e5a38 View commit details

   Browse the repository at this point in the history

4. test: use correct fieldname

   

   sagarvora committed Aug 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for da25924
   • Browse repository at this point

   Copy the full SHA

   da25924 View commit details

   Browse the repository at this point in the history

5. feat: rearranging standard fields in customize form (#19822) …

   * feat: rearranging standing fields
   
   * fix: fixed creation of property setter
   
   * refactor: renamed setup_sortable
   
   * fix: loading field_order property
   
   * refactor: removed redundant db call
   
   * fix: field_order not found
   
   * test: Added tests for field order in customize form
   
   * refactor: better naming
   
   * refactor: simplified logic
   
   * feat: Updating field order on custom field creation
   
   * feat: Added support for custom fiels
   
   * refactor: moving to meta
   
   * refactor: changed property type to json
   
   * fix: new standard field insert order.
   
   * fix: don't modify insert_after of system generated custom fields.
   
   # This is because system generated fields are to be treated as standard fields. If the user restores the form to default, this value will be used to reset the original position.
   
   # The new position of form fields are stored in the field_order Property Setter.
   
   * fix: treat system generated fields as standard fields when sorting.
   
   * revert: check for is_system_generated
   
   * Revert "fix: new standard field insert order."
   
   This reverts commit 6cdbe42.
   
   * fix: prioritize field_order over insert_after.
   
   # Use insert_after as fallback in event the field doesn't exist in field_order
   
   * fix(test): delete existing custom field
   
   * fix: order of standard fields without field_order property.
   
   * Revert "Revert "fix: new standard field insert order.""
   
   This reverts commit c830f1b.
   
   * test: field order of newly migrated standard fields.
   
   * fix(test): clear test_standard_field from previous test run.
   
   * fix: sort with insert_after for system generated fields.
   
   * fix(test): reset standard field creation before re-run and after successful test.
   
   * fix: insert_after position should be + 1
   
   * chore: remove debug statement
   
   * test: system generated customized fields
   
   * chore: remove print
   
   * chore: lint all
   
   * fix: show quick link to Table MultiSelect DocTypes
   
   * refactor: change backend implementation of `CustomizeForm` and `Meta`
   
   * test: simplify tests
   
   * fix: rename `idx` to `index` for clarity
   
   * perf: define `existing_fields` conditionally
   
   ---------
   
   Co-authored-by: Aradhya <aradhyatripathi51@gmail.com>
   Co-authored-by: Aradhya Tripathi <67282231+Aradhya-Tripathi@users.noreply.github.com>
   Co-authored-by: Sagar Vora <sagar@resilient.tech>

   

   4 people committed Aug 19, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 2cb7d54
   • Browse repository at this point

   Copy the full SHA

   2cb7d54 View commit details

   Browse the repository at this point in the history