feat: rearranging standard fields in customize form (backport #19822) #22121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: rearranging standing fields * fix: fixed creation of property setter * refactor: renamed setup_sortable * fix: loading field_order property * refactor: removed redundant db call * fix: field_order not found * test: Added tests for field order in customize form * refactor: better naming * refactor: simplified logic * feat: Updating field order on custom field creation * feat: Added support for custom fiels * refactor: moving to meta * refactor: changed property type to json * fix: new standard field insert order. * fix: don't modify insert_after of system generated custom fields. # This is because system generated fields are to be treated as standard fields. If the user restores the form to default, this value will be used to reset the original position. # The new position of form fields are stored in the field_order Property Setter. * fix: treat system generated fields as standard fields when sorting. * revert: check for is_system_generated * Revert "fix: new standard field insert order." This reverts commit 6cdbe42. * fix: prioritize field_order over insert_after. # Use insert_after as fallback in event the field doesn't exist in field_order * fix(test): delete existing custom field * fix: order of standard fields without field_order property. * Revert "Revert "fix: new standard field insert order."" This reverts commit c830f1b. * test: field order of newly migrated standard fields. * fix(test): clear test_standard_field from previous test run. * fix: sort with insert_after for system generated fields. * fix(test): reset standard field creation before re-run and after successful test. * fix: insert_after position should be + 1 * chore: remove debug statement * test: system generated customized fields * chore: remove print * chore: lint all * fix: show quick link to Table MultiSelect DocTypes * refactor: change backend implementation of `CustomizeForm` and `Meta` * test: simplify tests * fix: rename `idx` to `index` for clarity * perf: define `existing_fields` conditionally --------- Co-authored-by: Aradhya <aradhyatripathi51@gmail.com> Co-authored-by: Aradhya Tripathi <67282231+Aradhya-Tripathi@users.noreply.github.com> Co-authored-by: Sagar Vora <sagar@resilient.tech> (cherry picked from commit 19d211f) # Conflicts: # frappe/custom/doctype/customize_form/customize_form.js # frappe/custom/doctype/customize_form/test_customize_form.py
mergify
bot
requested review from
surajshetty3416
and removed request for
a team
|
cherry-picked in #22120 instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19822 done by Mergify.
Cherry-pick of 19d211f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com