fix(mobile): scroll issue after workspace change #24555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtdany10
requested review from
a team and
ankush
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24555 +/- ##
===========================================
+ Coverage 62.05% 62.14% +0.08%
===========================================
Files 786 786
Lines 75139 75140 +1
Branches 6436 6436
===========================================
+ Hits 46631 46692 +61
+ Misses 24852 24814 -38
+ Partials 3656 3634 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@rtdany10 thanks for the catch! |
|
Please backport as well @ankush |
ankush
added
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit eeac2bb)
mergify bot
pushed a commit
that referenced
this pull request
Jan 29, 2024
(cherry picked from commit eeac2bb)
akhilnarang
added a commit
that referenced
this pull request
Jan 29, 2024
…-24555 fix(mobile): scroll issue after workspace change (backport #24555)
ankush
pushed a commit
that referenced
this pull request
Jan 29, 2024
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
# [14.64.0](v14.63.0...v14.64.0) (2024-01-30) ### Bug Fixes * **Custom Field:** default fieldname in rename fieldname prompt ([#24492](#24492)) ([#24580](#24580)) ([7cdda1e](7cdda1e)) * **grid_row:** sort options based on selected data first, so as to maintain order ([b0e4b19](b0e4b19)) * ignore dead columns in user_settings ([#24572](#24572)) ([#24573](#24573)) ([5d2441d](5d2441d)) * improve translatability of search results ([#24498](#24498)) ([a74ba6c](a74ba6c)) * Missing traduction in the query popup ([051d622](051d622)) * **mobile:** scroll issue after workspace change ([#24555](#24555)) ([#24585](#24585)) ([7245292](7245292)) * Return empty result if no perm level access (backport [#24591](#24591)) ([#24592](#24592)) ([adcbeee](adcbeee)) * **search:** Fix URL encoding for search result ([#24558](#24558)) ([44ec1e3](44ec1e3)) * sentry minor fix ([#24588](#24588)) ([23f77ef](23f77ef)) * translatability ([#24553](#24553)) ([41d2fe2](41d2fe2)) ### Features * `frappe.db.sql` results `as_iterator` (backport [#19810](#19810)) (backport [#24346](#24346)) ([#24562](#24562)) ([7f3a12b](7f3a12b)), closes [#24365](#24365) ### Reverts * Revert "fix(data_import): respect the value of show_failed_logs checkbox" ([3c7f494](3c7f494))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
# [15.12.0](v15.11.0...v15.12.0) (2024-01-30) ### Bug Fixes * **Custom Field:** default fieldname in rename fieldname prompt ([#24492](#24492)) ([#24512](#24512)) ([b7e4a99](b7e4a99)) * Duplicate columns while configuring columns in New Print Format Builder ([#24520](#24520)) ([4595192](4595192)) * error when configuring child table columns in New Print Format Builder ([#24514](#24514)) ([5e9b68c](5e9b68c)) * **grid_row:** sort options based on selected data first, so as to maintain order ([7768444](7768444)) * ignore dead columns in user_settings ([#24572](#24572)) ([#24574](#24574)) ([2f82b11](2f82b11)) * improve translatability of search results ([#24499](#24499)) ([0ca8534](0ca8534)) * **meta:** Allow level 0 fields if a doc has been shared with user backport [#23904](#23904) ([#24595](#24595)) ([88b4455](88b4455)) * Missing traduction in the query popup ([d1196cb](d1196cb)) * **mobile:** scroll issue after workspace change ([#24555](#24555)) ([1facad9](1facad9)) * Return empty result if no perm level access ([#24591](#24591)) ([#24593](#24593)) ([289a1c3](289a1c3)) * **search:** Fix URL encoding for search result ([#24559](#24559)) ([c54d3d1](c54d3d1)) * sentry minor fix ([#24588](#24588)) ([1678601](1678601)) * set same cookie expiry as client side ([#24560](#24560)) ([#24568](#24568)) ([ffd68e7](ffd68e7)) * translatability ([#24554](#24554)) ([b6ca0e9](b6ca0e9)) * update all users after commit ([#24522](#24522)) ([#24523](#24523)) ([21eb062](21eb062)) ### Features * Configurable search link limit ([#24539](#24539)) ([#24540](#24540)) ([02b8281](02b8281)) * permission inspector (backport [#24239](#24239)) ([#24541](#24541)) ([cda63fb](cda63fb)) * show doctype description in list views ([#24583](#24583)) ([#24603](#24603)) ([279c3c0](279c3c0)) ### Reverts * Revert "fix(data_import): respect the value of show_failed_logs checkbox" ([f3d89d4](f3d89d4)) * added back quick list status indicator ([178580a](178580a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrollbar was missing after changing workspace in mobile view.
Introduced via #24312