Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore dead columns in user_settings #24572

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix: ignore dead columns in user_settings #24572

merged 1 commit into from
Jan 29, 2024

Conversation

ankush
Copy link
Member

@ankush ankush commented Jan 29, 2024 •
edited
Loading

When a deleted column is still configured in user defined columns for grid it breaks form rendering.

image

TypeError: o is undefined     
r grid.js:1227
    update_docfield_property grid.js:1227
    set_currency_labels form.js:1487
    each jQuery
    set_currency_labels form.js:1485
    update_item_grid_labels transaction.js:1386
    change_grid_labels transaction.js:1345
    set_dynamic_labels transaction.js:1289
    set_dynamic_labels sales_common.js:263
    refresh transaction.js:375
    refresh sales_common.js:94
    refresh delivery_note__js:137
    o script_manager.js:106
    trigger script_manager.js:136
    promise callback*frappe.run_serially/< dom.js:262
    run_serially dom.js:260
    trigger script_manager.js:141
    render_form form.js:612
    promise callback*frappe.run_serially/< dom.js:262
    run_serially dom.js:260
    render_form form.js:602
    initialize_new_doc form.js:571
    promise callback*initialize_new_doc form.js:568
    trigger_onload form.js:549
    refresh form.js:432
    render formview.js:107
    fetch_and_render formview.js:91
    callback model.js:317
    e request.js:85
    200 request.js:133
    call request.js:305
    jQuery 6
    call request.js:279
    call request.js:109
    with_doc model.js:309
    with_doc model.js:299
    fetch_and_render formview.js:80
    show_doc formview.js:75
    make_and_show formview.js:32
    make formview.js:15
    with_doctype model.js:232
    make formview.js:12
    show factory.js:25
    render_page router.js:323
    render router.js:302
    route router.js:157
    set_route desk.js:161
    startup desk.js:92
    <anonymous> desk.js:30
    start_app desk.js:12
    <anonymous> desk.js:25
    jQuery 13
    Gi libs.bundle.TIV7ZGVY.js:1
    <anonymous> jQuery
    <anonymous>

@ankush ankush requested review from a team and akhilnarang and removed request for a team January 29, 2024 07:36
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Jan 29, 2024
@ankush ankush merged commit 555bed3 into frappe:develop Jan 29, 2024
23 of 24 checks passed
@ankush ankush deleted the fix_ignore_dead_columns branch January 29, 2024 07:44
mergify bot pushed a commit that referenced this pull request Jan 29, 2024
@ankush @mergify
fix: ignore dead columns in user_settings (#24572)
7b44ee2 
(cherry picked from commit 555bed3)
@mergify mergify bot mentioned this pull request Jan 29, 2024
Merged
mergify bot pushed a commit that referenced this pull request Jan 29, 2024
@ankush @mergify
fix: ignore dead columns in user_settings (#24572)
0aaba69 
(cherry picked from commit 555bed3)
@mergify mergify bot mentioned this pull request Jan 29, 2024
Merged
ankush added a commit that referenced this pull request Jan 29, 2024
@mergify @ankush
fix: ignore dead columns in user_settings (#24572) (#24573)
5d2441d 
(cherry picked from commit 555bed3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request Jan 29, 2024
@mergify @ankush
fix: ignore dead columns in user_settings (#24572) (#24574)
2f82b11 
(cherry picked from commit 555bed3)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Jan 30, 2024
@frappe-bot
chore(release): Bumped to Version 14.64.0
6d8fbac 
# [14.64.0](v14.63.0...v14.64.0) (2024-01-30)

### Bug Fixes

* **Custom Field:** default fieldname in rename fieldname prompt ([#24492](#24492)) ([#24580](#24580)) ([7cdda1e](7cdda1e))
* **grid_row:** sort options based on selected data first, so as to maintain order ([b0e4b19](b0e4b19))
* ignore dead columns in user_settings ([#24572](#24572)) ([#24573](#24573)) ([5d2441d](5d2441d))
* improve translatability of search results ([#24498](#24498)) ([a74ba6c](a74ba6c))
* Missing traduction in the query popup ([051d622](051d622))
* **mobile:** scroll issue after workspace change ([#24555](#24555)) ([#24585](#24585)) ([7245292](7245292))
* Return empty result if no perm level access (backport [#24591](#24591)) ([#24592](#24592)) ([adcbeee](adcbeee))
* **search:** Fix URL encoding for search result ([#24558](#24558)) ([44ec1e3](44ec1e3))
* sentry minor fix ([#24588](#24588)) ([23f77ef](23f77ef))
* translatability ([#24553](#24553)) ([41d2fe2](41d2fe2))

### Features

* `frappe.db.sql` results `as_iterator` (backport [#19810](#19810)) (backport [#24346](#24346)) ([#24562](#24562)) ([7f3a12b](7f3a12b)), closes [#24365](#24365)

### Reverts

* Revert "fix(data_import): respect the value of show_failed_logs checkbox" ([3c7f494](3c7f494))
frappe-pr-bot pushed a commit that referenced this pull request Jan 30, 2024
@frappe-bot
chore(release): Bumped to Version 15.12.0
ead7efa 
# [15.12.0](v15.11.0...v15.12.0) (2024-01-30)

### Bug Fixes

* **Custom Field:** default fieldname in rename fieldname prompt ([#24492](#24492)) ([#24512](#24512)) ([b7e4a99](b7e4a99))
* Duplicate columns while configuring columns in New Print Format Builder ([#24520](#24520)) ([4595192](4595192))
* error when configuring child table columns in New Print Format Builder ([#24514](#24514)) ([5e9b68c](5e9b68c))
* **grid_row:** sort options based on selected data first, so as to maintain order ([7768444](7768444))
* ignore dead columns in user_settings ([#24572](#24572)) ([#24574](#24574)) ([2f82b11](2f82b11))
* improve translatability of search results ([#24499](#24499)) ([0ca8534](0ca8534))
* **meta:** Allow level 0 fields if a doc has been shared with user backport [#23904](#23904) ([#24595](#24595)) ([88b4455](88b4455))
* Missing traduction in the query popup ([d1196cb](d1196cb))
* **mobile:** scroll issue after workspace change ([#24555](#24555)) ([1facad9](1facad9))
* Return empty result if no perm level access ([#24591](#24591)) ([#24593](#24593)) ([289a1c3](289a1c3))
* **search:** Fix URL encoding for search result ([#24559](#24559)) ([c54d3d1](c54d3d1))
* sentry minor fix ([#24588](#24588)) ([1678601](1678601))
* set same cookie expiry as client side ([#24560](#24560)) ([#24568](#24568)) ([ffd68e7](ffd68e7))
* translatability ([#24554](#24554)) ([b6ca0e9](b6ca0e9))
* update all users after commit ([#24522](#24522)) ([#24523](#24523)) ([21eb062](21eb062))

### Features

* Configurable search link limit ([#24539](#24539)) ([#24540](#24540)) ([02b8281](02b8281))
* permission inspector (backport [#24239](#24239)) ([#24541](#24541)) ([cda63fb](cda63fb))
* show doctype description in list views ([#24583](#24583)) ([#24603](#24603)) ([279c3c0](279c3c0))

### Reverts

* Revert "fix(data_import): respect the value of show_failed_logs checkbox" ([f3d89d4](f3d89d4))
* added back quick list status indicator ([178580a](178580a))
@barredterra barredterra mentioned this pull request Feb 5, 2024
Closed
@barredterra barredterra mentioned this pull request Feb 12, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akhilnarang akhilnarang Awaiting requested review from akhilnarang

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ankush