fix: Use TEXT type for Webhook URLs to support large URLs
#24761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
a team and
surajshetty3416
and removed request for
a team
ankush
added
backport version-14-hotfix
This was referenced Feb 5, 2024
ankush
added a commit
that referenced
this pull request
Feb 5, 2024
…24761) (#24762) * fix: Use `TEXT` type for Webhook URLs to support large URLs (cherry picked from commit 063e309) # Conflicts: # frappe/integrations/doctype/webhook/webhook.json # frappe/integrations/doctype/webhook/webhook.py * chore: conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
# [14.65.0](v14.64.0...v14.65.0) (2024-02-06) ### Bug Fixes * Allow int fields to be unique ([#24750](#24750)) ([#24755](#24755)) ([7f19ea2](7f19ea2)) * Check if header/footer html exists before trying to extract ([c1dc4b9](c1dc4b9)) * Custom Script runs twice ([a70de37](a70de37)) * data import table UI fix ([d3d3354](d3d3354)) * do not allow to set if_owner & report perm together ([40a0065](40a0065)) * enable syntax highlighting for `PythonExpression` code fields ([#24669](#24669)) ([#24670](#24670)) ([666040c](666040c)) * Enqueue deletion of dynamic link after comitting ([#24674](#24674)) ([9eb9878](9eb9878)) * Extract header/footer html into `content` to simplify things ([2d11989](2d11989)) * **js:** Handle hidden virtual fields ([#24405](#24405)) ([#24691](#24691)) ([50c18ab](50c18ab)) * Make as_iterator work when there are no child queries ([#24748](#24748)) ([40d5741](40d5741)) * make rate_limiter respect multitenancy (backport [#24634](#24634)) ([#24635](#24635)) ([e49a5a0](e49a5a0)) * Missing `footer_html ` declaration ([d75dfef](d75dfef)) * outgoing email account handlng (backport [#24656](#24656)) ([#24685](#24685)) ([9ba3c9e](9ba3c9e)) * short circuit private files perm check ([b2d105a](b2d105a)) * show folders in Google Drive Picker ([e5f1137](e5f1137)), closes [#23096](#23096) * Show proper error message for prepared report failure ([#24733](#24733)) ([#24736](#24736)) ([379d893](379d893)) * Skip fulltext indexes during sync ([#24728](#24728)) ([#24732](#24732)) ([1a8e049](1a8e049)) * Translate Letterhead information string ([00c4b77](00c4b77)) * typeerror in onboarding_tours.js ([7cca45f](7cca45f)) * Use `TEXT` type for Webhook URLs to support large URLs (backport [#24761](#24761)) ([#24762](#24762)) ([e5ff86a](e5ff86a)) * virtual fields are never writable ([#24693](#24693)) ([#24695](#24695)) ([22e26f6](22e26f6)) ### Features * Dynamic headers/footers & fix disappearing header ([343ac16](343ac16)) * Include letterhead scripts in print (html) ([5321e5d](5321e5d)) ### Performance Improvements * optional faster perm check for files (backport [#24624](#24624)) ([#24630](#24630)) ([6778fe2](6778fe2))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24527