fix(patch): Remove obviously invalid fetch from expressions #25284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
a team and
akhilnarang
and removed request for
a team
github-actions
bot
added
the
add-test-cases
mergify bot
pushed a commit
that referenced
this pull request
Mar 10, 2024
(cherry picked from commit 4f4a387) # Conflicts: # frappe/patches.txt
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
## [15.17.2](v15.17.1...v15.17.2) (2024-03-12) ### Bug Fixes * Add `is_virtual` in bootstrap schema ([cf8078d](cf8078d)) * **auto_email_report:** check if column (docfield) parent is a child table ([#25335](#25335)) ([#25342](#25342)) ([a870b5a](a870b5a)) * commit before ddl ([092bd0e](092bd0e)) * commit regardless of framework's transaction_writes count ([#25322](#25322)) ([#25328](#25328)) ([c7c726e](c7c726e)) * delete doctype cache before starting migration ([74a8d87](74a8d87)) * Delete EPS logs before deleting user ([1f47f7a](1f47f7a)) * do not mark custom field as translatable by default ([#25330](#25330)) ([841d885](841d885)) * dont set fetch from if partial ([800298d](800298d)) * formatting ([7f147b1](7f147b1)) * ignore route history and access log from link check ([5061a08](5061a08)) * list view click and drag select rows ([24d713e](24d713e)) * loosen validation on fetch from columns ([#25247](#25247)) ([0c934de](0c934de)) * MacOS shortcuts (backport [#25272](#25272)) ([#25280](#25280)) ([785b5c2](785b5c2)) * missing timeline timestamp for comments ([27357fb](27357fb)), closes [/github.com//pull/24884/files#r1519195726](https://github.com//github.com/frappe/frappe/pull/24884/files/issues/r1519195726) * **ModuleDef:** Add list view filter options to app_name Select ([7357c5e](7357c5e)) * **patch:** Remove obviously invalid fetch from expressions (backport [#25284](#25284)) ([#25302](#25302)) ([0ec4bc8](0ec4bc8)) * rollback invalid customize form changes ([#25198](#25198)) ([d6bff86](d6bff86)) * Setup fail if fail function exists ([4d5e453](4d5e453)) * Skip virtual doctypes in link field checks ([#24759](#24759)) ([#25333](#25333)) ([45499c2](45499c2)) * **uninstall:** don't allow uninstalling an app if we have other apps dependent on it ([b631112](b631112)) * Use debug log to log DB queries (backport [#25265](#25265)) ([#25301](#25301)) ([24479ca](24479ca)) * **UX:** Nudge to disable user instead of deleting ([1da957f](1da957f)) ### Performance Improvements * Add optional socketio native packages ([160cf29](160cf29)) ### Reverts * fetch validations (backport [#25343](#25343)) ([#25344](#25344)) ([f729817](f729817)) * fetch validations (backport [#25343](#25343)) ([#25345](#25345)) ([7cc3686](7cc3686))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25281 because of this bug there can be many invalid expressions stored in DB. This patch removes them all, they are not doing anything anyway.