Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exporter): we want DF.Literal[None], not DF.LiteralNone #25392

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

akhilnarang
Copy link
Member

@akhilnarang akhilnarang commented Mar 13, 2024

Broke in #25211

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@akhilnarang akhilnarang requested review from a team and ankush and removed request for a team March 13, 2024 10:28
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Mar 13, 2024
@akhilnarang akhilnarang changed the title fix: we want DF.Literal[None], not DF.LiteralNone fix(exporter): we want DF.Literal[None], not DF.LiteralNone Mar 13, 2024
@akhilnarang akhilnarang added the backport version-15-hotfix Backport the PR to v15 label Mar 13, 2024
@ankush ankush removed the add-test-cases Add test case to validate fix or enhancement label Mar 13, 2024
@akhilnarang akhilnarang merged commit d075de8 into frappe:develop Mar 13, 2024
24 checks passed
@akhilnarang akhilnarang deleted the fix-type-exporter branch March 13, 2024 11:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants