fix: Export None as type if select as no options
#25211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
Select options can be dynamic, in that case we should at least the default value `None` as a value `DF.Literal` otherwise is invalid type annotation.
ankush
force-pushed
the
type_exporter_no_select
branch
from
ed9fe55
to
ddcf327
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Select options can be dynamic, in that case we should at least the default value `None` as a value `DF.Literal` otherwise is invalid type annotation. (cherry picked from commit b1a8bc9) # Conflicts: # frappe/automation/doctype/milestone_tracker/milestone_tracker.py # frappe/email/doctype/notification/notification.py # frappe/social/doctype/energy_point_rule/energy_point_rule.py
ankush
added a commit
that referenced
this pull request
Mar 4, 2024
Select options can be dynamic, in that case we should at least the default value `None` as a value `DF.Literal` otherwise is invalid type annotation. (cherry picked from commit b1a8bc9) # Conflicts: # frappe/automation/doctype/milestone_tracker/milestone_tracker.py # frappe/email/doctype/notification/notification.py # frappe/social/doctype/energy_point_rule/energy_point_rule.py Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
# [15.17.0](v15.16.1...v15.17.0) (2024-03-05) ### Bug Fixes * add "If Owner" column to roles viewer ([#25218](#25218)) ([#25220](#25220)) ([adf6a2a](adf6a2a)) * always show is_standard on web form ([#25144](#25144)) ([#25148](#25148)) ([196483b](196483b)) * better error message ([b94e978](b94e978)) * dont translate numbers ([#25208](#25208)) ([#25210](#25210)) ([c659eca](c659eca)) * escalate print failures ([a987c2d](a987c2d)) * escape single quotes ([#25104](#25104)) ([#25154](#25154)) ([adb7e38](adb7e38)), closes [/github.com//pull/25078#discussion_r1504084483](https://github.com//github.com/frappe/frappe/pull/25078/issues/discussion_r1504084483) * Export `None` as type if select as no options ([#25211](#25211)) ([#25212](#25212)) ([79a8afd](79a8afd)) * filter Implementation is set operator ([#25182](#25182)) ([#25195](#25195)) ([20a7879](20a7879)), closes [#25180](#25180) * No need to sort keys while saving JSON to DB ([#25205](#25205)) ([#25206](#25206)) ([a471499](a471499)) * Only validate fetch from when user modifies it ([72da497](72da497)) * race condition on deletes (backport [#25170](#25170)) ([#25171](#25171)) ([1657d55](1657d55)) * **search:** Don't break when query doesn't return title ([#25168](#25168)) ([#25197](#25197)) ([3dafbf9](3dafbf9)) * **setup_module_map:** fix caching ([338c895](338c895)) * specify print_language in communication attachments ([4e53b12](4e53b12)) * task_id parameter for publish_progress ([30a2f27](30a2f27)) * update file attached_to details in submitted doc ([#25141](#25141)) ([73f1a73](73f1a73)) * Use current language in attachment prints ([ea4c11b](ea4c11b)) * use name for RQ worker instead of PID ([#25175](#25175)) ([#25177](#25177)) ([7264734](7264734)) * **UX:** correctly disable standard web form form ([#25143](#25143)) ([2d907e7](2d907e7)) * **UX:** list filter take zero as null ([#25156](#25156)) ([#25222](#25222)) ([963ff89](963ff89)) * **UX:** reload form after renaming field ([#25159](#25159)) ([#25161](#25161)) ([7754e4a](7754e4a)) * **UX:** set default print language from print format ([c11f140](c11f140)) ### Features * Add doc rename hook in server script ([#25085](#25085)) ([#25110](#25110)) ([b729c03](b729c03)) * let users unlock stuck documents (backport [#24782](#24782)) ([#25225](#25225)) ([b0db641](b0db641)) * task_id for submit_cancel_or_update_docs ([bf8d102](bf8d102))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select options can be dynamic, in that case we should at least the
default value
Noneas a valueDF.Literalotherwise is invalid typeannotation.