feat: connect to redis sentinel for redis cache

[revant]

Please provide enough information so that others can review your pull request:

Use redis sentinel for redis cache connection. It is setup for production only using extra keys from common_site_config.json

Explain the details for making this change. What existing problem does the pull request solve?

At the moment we can connect to single redis master for cache. With this we can connect to sentinel cluster.

https://redis.io/docs/management/sentinel

To try it with frappe_docker/devcontainer make following changes to .devcontainer/docker-compose.yml

version: "3.7"
services:
  mariadb:
    image: docker.io/mariadb:10.6
    command:
      - --character-set-server=utf8mb4
      - --collation-server=utf8mb4_unicode_ci
      - --skip-character-set-client-handshake
      - --skip-innodb-read-only-compressed # Temporary fix for MariaDB 10.6
    environment:
      - MYSQL_ROOT_PASSWORD=123
    volumes:
      - mariadb-data:/var/lib/mysql

  redis-cache:
    image: redis:alpine

  redis-queue:
    image: redis:alpine


## Change begins here ##
  redis-cache-sentinel:
    image: docker.io/bitnami/redis-sentinel:7.2
    environment:
      - REDIS_SENTINEL_PASSWORD=sentinelpassword
      - REDIS_MASTER_HOST=redis-cache-master
      - REDIS_MASTER_PASSWORD=masterpassword

  redis-cache-master:
    image: docker.io/bitnami/redis:7.2
    environment:
      - REDIS_PASSWORD=masterpassword
## Change ends here ##

  frappe:
    image: docker.io/frappe/bench:latest
    command: sleep infinity
    environment:
      - SHELL=/bin/bash
    volumes:
      - ..:/workspace:cached
      - ${HOME}/.ssh:/home/frappe/.ssh
    working_dir: /workspace/development
    ports:
      - 8000-8005:8000-8005
      - 9000-9005:9000-9005

volumes:
  mariadb-data:

add redis_cache_* keys to common_site_config.json

{
 "background_workers": 1,
 "db_host": "mariadb",
 "db_type": "mariadb",
 "developer_mode": 1,
 "file_watcher_port": 6788,
 "frappe_user": "frappe",
 "gunicorn_workers": 25,
 "live_reload": true,
 "rebase_on_pull": false,
 "redis_socketio": "redis://redis-queue:6379",
 "redis_cache": "redis://redis-cache:6379",
 "redis_cache_sentinel_enabled": 1,
 "redis_cache_sentinels": ["redis-cache-sentinel:26379"],
 "redis_cache_sentinel_password": "sentinelpassword",
 "redis_cache_master_service": "mymaster",
 "redis_cache_master_password": "masterpassword",
 "redis_queue": "redis://redis-queue:6379",
 "restart_supervisor_on_update": false,
 "restart_systemd_on_update": false,
 "serve_default_site": true,
 "shallow_clone": true,
 "socketio_port": 9000,
 "use_redis_auth": false,
 "webserver_port": 8000
}

Note: Nothing has changed to the redis_cache key. It will be used during development setup by bench watch command.

Screenshots/GIFs

To do:

• Docs

[revant]

Why just cache?

I tried for queue and got following error:

(env) frappe@996d1f114c90:/workspace/development/develop-bench$ bench worker
2024-03-13 11:02:03,020 Worker rq:worker:ef858235b868482bbe438d15d0cac22d started with PID 6572, version 1.15.1
2024-03-13 11:02:03,020 Subscribing to channel rq:pubsub:ef858235b868482bbe438d15d0cac22d
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/home/frappe/.pyenv/versions/3.11.6/lib/python3.11/threading.py", line 1045, in _bootstrap_inner
    self.run()
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/client.py", line 1799, in run
    pubsub.get_message(ignore_subscribe_messages=True, timeout=sleep_time)
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/client.py", line 1690, in get_message
    response = self.parse_response(block=(timeout is None), timeout=timeout)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/client.py", line 1542, in parse_response
2024-03-13 11:02:03,021 *** Listening on workspace-development-develop-bench:short, workspace-development-develop-bench:default, workspace-development-develop-bench:long...
    response = self._execute(conn, try_read)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/client.py", line 1518, in _execute
    return conn.retry.call_with_retry(
2024-03-13 11:02:03,022 Cleaning registries for queue: workspace-development-develop-bench:short
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/retry.py", line 46, in call_with_retry
    return do()
           ^^^^
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/client.py", line 1519, in <lambda>
    lambda: command(*args, **kwargs),
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspace/development/develop-bench/env/lib/python3.11/site-packages/redis/client.py", line 1540, in try_read
    return conn.read_response(disconnect_on_error=False)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: SentinelManagedConnection.read_response() got an unexpected keyword argument 'disconnect_on_error'
2024-03-13 11:02:03,023 Cleaning registries for queue: workspace-development-develop-bench:default
2024-03-13 11:02:03,023 Cleaning registries for queue: workspace-development-develop-bench:long

Also nothing figured out about to socketio connecting to sentinel redis_queue