Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APIv2): Add comment via REST API #25889

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat(APIv2): Add comment via REST API #25889

merged 1 commit into from
Apr 10, 2024

Conversation

ankush
Copy link
Member

@ankush ankush commented Apr 10, 2024

POST /document/Sales Order/S0-123/method/add_comment
{
    text: "Comment"
}

Towards #22762

```
POST /document/Sales Order/S0-123/add_comment
{
    text: "Comment"
}
```
@ankush ankush requested a review from a team as a code owner April 10, 2024 05:22
@ankush ankush requested review from akhilnarang and removed request for a team April 10, 2024 05:22
@ankush ankush mentioned this pull request Apr 10, 2024
15 tasks
@ankush ankush enabled auto-merge (squash) April 10, 2024 05:48
@ankush ankush added the backport version-15-hotfix Backport the PR to v15 label Apr 10, 2024
@ankush
Copy link
Member Author

ankush commented Apr 10, 2024

Not sure why postgres is failing 🗿

@akhilnarang
Copy link
Member

Not sure why postgres is failing 🗿

image
Just happened to run when httpbin was down maybe?

@ankush ankush merged commit caf7aec into frappe:develop Apr 10, 2024
23 of 24 checks passed
@ankush ankush deleted the api_v22 branch April 10, 2024 10:53
mergify bot pushed a commit that referenced this pull request Apr 10, 2024
```
POST /document/Sales Order/S0-123/add_comment
{
    text: "Comment"
}
```

(cherry picked from commit caf7aec)
@ankush
Copy link
Member Author

ankush commented Apr 10, 2024

@akhilnarang ah, it's not supposed to happen. I mocked all external requests a while ago 😅

@ankush
Copy link
Member Author

ankush commented Apr 10, 2024

precisely for this reason

ankush added a commit that referenced this pull request Apr 10, 2024
```
POST /document/Sales Order/S0-123/add_comment
{
    text: "Comment"
}
```

(cherry picked from commit caf7aec)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Apr 16, 2024
# [15.23.0](v15.22.0...v15.23.0) (2024-04-16)

### Bug Fixes

* filter button translation ([#25944](#25944)) ([2bea73a](2bea73a))
* frm can be missing ([9e227b0](9e227b0))
* handle empty style tag ([#25910](#25910)) ([#25916](#25916)) ([34fbf6d](34fbf6d))
* handle interface error during report timeout ([#25893](#25893)) ([#25895](#25895)) ([6784b5d](6784b5d))
* let's color tag in form view ([#25949](#25949)) ([#25954](#25954)) ([0e6820d](0e6820d))
* limit title length on form ([#25880](#25880)) ([fb24480](fb24480))
* log out reliability ([#25865](#25865)) ([72b4540](72b4540))
* make letterhead attachments public by default ([#25925](#25925)) ([#25927](#25927)) ([c5c3424](c5c3424))
* private workspace routing (backport [#25904](#25904)) ([#25921](#25921)) ([c4eeb2e](c4eeb2e))
* reset announcements after saving settings ([b4ee409](b4ee409))
* show warning for pending migrations ([#25908](#25908)) ([#25909](#25909)) ([026514e](026514e)), closes [#25880](#25880)
* title width for form ([#25958](#25958)) ([#25959](#25959)) ([7a884e2](7a884e2))
* toolbar condition for setting up widget ([e42593e](e42593e))
* use boot to store announcement ([5f14e68](5f14e68))
* use localStorage for widget content ([642db78](642db78))

### Features

* add html for widget below navbar ([ea76002](ea76002))
* add option to filter email recipients ([c175911](c175911))
* add option to set default email recipients ([#25555](#25555)) ([bc496c1](bc496c1))
* allow wildcard for doctype in permission hooks ([#25729](#25729)) ([#25892](#25892)) ([7a4fa2f](7a4fa2f))
* announcement widget in navbar settings ([a947f44](a947f44))
* **APIv2:** Add comment via REST API ([#25889](#25889)) ([#25901](#25901)) ([2751be3](2751be3))
* **Customize Form:** add "Trim Table" action (backport [#25923](#25923)) ([#25933](#25933)) ([aa32595](aa32595))
* delete failed backups ([615cd71](615cd71))
* setup widget in toolbar ([e011cfa](e011cfa))

### Reverts

* Revert "test(UI): navbar announcements" ([3b23054](3b23054))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants