perf: Avoid coalesce for between filters (backport #26531)
#26533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 28, 2024
# [14.76.0](v14.75.0...v14.76.0) (2024-05-28) ### Bug Fixes * Appropriate variable name, avoid redefining parameter ([83cf2df](83cf2df)) * reload before saving on reconnect ([#26534](#26534)) ([#26536](#26536)) ([b2d17c1](b2d17c1)) * Use true stderr for dumping trace ([#26524](#26524)) ([#26526](#26526)) ([30676fb](30676fb)) ### Features * Add `on_add_row` event for grid in Dialog ([8db7fcd](8db7fcd)) ### Performance Improvements * Avoid coalesce for `between` filters ([#26531](#26531)) ([#26533](#26533)) ([446780c](446780c))
|
🎉 This PR is included in version 14.76.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Between operator never needs to check for null.
Explanation: Consider SQL ->
COLUMN between X and YActual computation:
Since Y and X can't be null, null value in column will never match this filter, so coalesce is extra cost that prevents index usage.
Same logic applies for
DATETIME_FIELD > X, as X is not null, DATETIME_FIELD will never match the filter if it's null, so no need check forifnull.This is an automatic backport of pull request #26531 done by Mergify.