Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload before saving on reconnect #26534

Merged
merged 1 commit into from
May 22, 2024

Conversation

ankush
Copy link
Member

@ankush ankush commented May 22, 2024

The doc we have might be "in future".

@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels May 22, 2024
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label May 22, 2024
The doc we have might be "in future".
@ankush ankush merged commit 9e9e72b into frappe:develop May 22, 2024
23 checks passed
@ankush ankush deleted the reload_before_save branch May 22, 2024 11:01
mergify bot pushed a commit that referenced this pull request May 22, 2024
The doc we have might be "in future".

(cherry picked from commit 9e9e72b)
mergify bot pushed a commit that referenced this pull request May 22, 2024
The doc we have might be "in future".

(cherry picked from commit 9e9e72b)
ankush added a commit that referenced this pull request May 22, 2024
The doc we have might be "in future".

(cherry picked from commit 9e9e72b)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request May 22, 2024
The doc we have might be "in future".

(cherry picked from commit 9e9e72b)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request May 28, 2024
# [14.76.0](v14.75.0...v14.76.0) (2024-05-28)

### Bug Fixes

* Appropriate variable name, avoid redefining parameter ([83cf2df](83cf2df))
* reload before saving on reconnect ([#26534](#26534)) ([#26536](#26536)) ([b2d17c1](b2d17c1))
* Use true stderr for dumping trace ([#26524](#26524)) ([#26526](#26526)) ([30676fb](30676fb))

### Features

* Add `on_add_row` event for grid in Dialog ([8db7fcd](8db7fcd))

### Performance Improvements

* Avoid coalesce for `between` filters ([#26531](#26531)) ([#26533](#26533)) ([446780c](446780c))
frappe-pr-bot pushed a commit that referenced this pull request May 28, 2024
# [15.29.0](v15.28.0...v15.29.0) (2024-05-28)

### Bug Fixes

* Appropriate variable name, avoid redefining parameter ([a75c031](a75c031))
* child table field wildcard in API ([#26543](#26543)) ([#26560](#26560)) ([20ac585](20ac585))
* Drop file_manager.download_file ([#26575](#26575)) ([#26577](#26577)) ([6ace16b](6ace16b))
* ignore apps without pyproject ([#26498](#26498)) ([#26503](#26503)) ([6c3c798](6c3c798))
* reload before saving on reconnect ([#26534](#26534)) ([#26537](#26537)) ([22e278f](22e278f))
* Use true stderr for dumping trace ([#26524](#26524)) ([#26527](#26527)) ([e7e55db](e7e55db))

### Features

* Add `on_add_row` event for grid in Dialog ([e592b87](e592b87))
* ignore `tar: file changed as we read it` during backups (backport [#26462](#26462)) ([#26495](#26495)) ([30f767e](30f767e))
* Option to make webform embeddable ([f08fff5](f08fff5))

### Performance Improvements

* Avoid coalesce for `between` filters ([#26531](#26531)) ([#26532](#26532)) ([8263898](8263898))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant