fix: apply perms on letter head selection (backport #26563) #26582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
barredterra
approved these changes
May 27, 2024
|
The failing UI test seems unrelated |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
## [14.76.2](v14.76.1...v14.76.2) (2024-06-11) ### Bug Fixes * apply perms on letter head selection (backport [#26563](#26563)) ([#26582](#26582)) ([06854e5](06854e5)) * Email tracking without "use_ssl" (backport [#26718](#26718)) ([#26734](#26734)) ([478f84e](478f84e)) * **package_release:** set path to tarball ([b48037a](b48037a)) * recursive fetch from causes infinite loop ([#26695](#26695)) ([#26696](#26696)) ([2f9f4bc](2f9f4bc)) * Skip letter heads if no permission (backport [#26689](#26689)) ([#26691](#26691)) ([7a1dc7d](7a1dc7d)) * Skip virtual fields in all select queries (backport [#26700](#26700)) ([#26701](#26701)) ([cdab21f](cdab21f)) * **UX:** Disable number card filters on standard ([#26676](#26676)) ([#26679](#26679)) ([5810549](5810549))
|
🎉 This PR is included in version 14.76.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
akhilnarang
added a commit
that referenced
this pull request
Jun 19, 2024
…-25050 * version-14-hotfix: (29 commits) refactor(web list): use CSS class `d-none` instead of `hidden` fix: auto filter publish field (#26151) fix(desk): Don't trigger minimized dialog action on Ctrl-S fix(query_report): don't follow reference report for `prepared_report` field fix: avoid popping from empty list feat: set the only email address as primary fix: shorten_number fix: Email tracking without "use_ssl" (backport #26718) (#26734) fix(package_release): set path to tarball chore: Reword "Recursive Fetch From" message (#26706) (#26707) fix: Skip virtual fields in all select queries (backport #26700) (#26701) fix: recursive fetch from causes infinite loop (#26695) (#26696) fix: Skip letter heads if no permission (backport #26689) (#26691) fix: apply perms on letter head selection (backport #26563) (#26582) fix(UX): Disable number card filters on standard (#26676) (#26679) test: pin cypress fix: fail on cypress install failure fix: Auto Email Report not working when Add Total Row is enabled (#26667) perf: use base32 space for random names instead of base16 (backport #25497) (#26655) fix(make_request): don't blindly try to check the content-type ... Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all desk users have read access on all Letter Heads. However, this can be further restricted by custom Role- and User Permissions. The print settings dialog and the Letter Head list in
frappe.boot.letter_headsdidn't respect these permissions.Fixes:
get_listfor constructingfrappe.boot.letter_heads.This is an automatic backport of pull request fix: apply perms on letter head selection #26563 done by Mergify.