Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip letter heads if no permission #26689

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ankush
Copy link
Member

@ankush ankush commented Jun 5, 2024

#26563 This cases boot to fail for users if they don't have letterhead access.

@ankush ankush requested review from a team and akhilnarang and removed request for a team June 5, 2024 15:44
@ankush ankush enabled auto-merge (squash) June 5, 2024 15:44
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Jun 5, 2024
@ankush ankush added backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15 labels Jun 5, 2024
@ankush
Copy link
Member Author

ankush commented Jun 5, 2024

@Mergifyio backport version-15

Copy link
Contributor

mergify bot commented Jun 5, 2024

backport version-15

✅ Backports have been created

@ankush ankush merged commit 63a13d0 into frappe:develop Jun 5, 2024
24 checks passed
@ankush ankush deleted the letter_head_perm branch June 5, 2024 15:56
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
(cherry picked from commit 63a13d0)

# Conflicts:
#	frappe/boot.py
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
(cherry picked from commit 63a13d0)

# Conflicts:
#	frappe/boot.py
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
ankush added a commit that referenced this pull request Jun 5, 2024
(cherry picked from commit 63a13d0)

Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush added a commit that referenced this pull request Jun 5, 2024
* fix: Skip letter heads if no permission (#26689)

(cherry picked from commit 63a13d0)

# Conflicts:
#	frappe/boot.py

* Update boot.py

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
earona pushed a commit to NovigoTechnology/frappe that referenced this pull request Jun 6, 2024
## [15.0.3](v15.0.2-Novigo...v15.0.3-Novigo) (2024-06-06)

### Bug Fixes

* recursive fetch from causes infinite loop ([frappe#26695](https://github.com/NovigoTechnology/frappe/issues/26695)) ([ab37665](ab37665))
* Skip letter heads if no permission ([frappe#26689](https://github.com/NovigoTechnology/frappe/issues/26689)) ([63a13d0](63a13d0))
* Skip virtual fields in all select queries ([frappe#26700](https://github.com/NovigoTechnology/frappe/issues/26700)) ([820a6ed](820a6ed))
* **UX:** Show reference name in error log list view [frappe#26687](https://github.com/NovigoTechnology/frappe/issues/26687) ([a2bff44](a2bff44))
frappe-pr-bot pushed a commit that referenced this pull request Jun 11, 2024
## [15.29.2](v15.29.1...v15.29.2) (2024-06-11)

### Bug Fixes

* Append symbol on number card ([#26731](#26731)) ([#26732](#26732)) ([38457a5](38457a5))
* apply perms on letter head selection (backport [#26563](#26563)) ([#26583](#26583)) ([ef4bb3b](ef4bb3b))
* Email tracking without "use_ssl" ([#26718](#26718)) ([#26735](#26735)) ([f78d8f8](f78d8f8))
* Move Monitor dump to after_response ([#26703](#26703)) ([#26709](#26709)) ([c24ee13](c24ee13))
* **package_release:** set path to tarball ([9606348](9606348))
* recursive fetch from causes infinite loop ([#26695](#26695)) ([#26697](#26697)) ([9c33352](9c33352))
* Skip letter heads if no permission ([#26689](#26689)) ([#26692](#26692)) ([c9b5df3](c9b5df3))
* Skip virtual fields in all select queries ([#26700](#26700)) ([#26702](#26702)) ([3797f8f](3797f8f))
* **UX:** Disable number card filters on standard ([#26676](#26676)) ([#26680](#26680)) ([58f154f](58f154f))
frappe-pr-bot pushed a commit that referenced this pull request Jun 11, 2024
## [14.76.2](v14.76.1...v14.76.2) (2024-06-11)

### Bug Fixes

* apply perms on letter head selection (backport [#26563](#26563)) ([#26582](#26582)) ([06854e5](06854e5))
* Email tracking without "use_ssl" (backport [#26718](#26718)) ([#26734](#26734)) ([478f84e](478f84e))
* **package_release:** set path to tarball ([b48037a](b48037a))
* recursive fetch from causes infinite loop ([#26695](#26695)) ([#26696](#26696)) ([2f9f4bc](2f9f4bc))
* Skip letter heads if no permission (backport [#26689](#26689)) ([#26691](#26691)) ([7a1dc7d](7a1dc7d))
* Skip virtual fields in all select queries (backport [#26700](#26700)) ([#26701](#26701)) ([cdab21f](cdab21f))
* **UX:** Disable number card filters on standard ([#26676](#26676)) ([#26679](#26679)) ([5810549](5810549))
akhilnarang added a commit that referenced this pull request Jun 19, 2024
…-25050

* version-14-hotfix: (29 commits)
  refactor(web list): use CSS class `d-none` instead of `hidden`
  fix: auto filter publish field (#26151)
  fix(desk): Don't trigger minimized dialog action on Ctrl-S
  fix(query_report): don't follow reference report for `prepared_report` field
  fix: avoid popping from empty list
  feat: set the only email address as primary
  fix: shorten_number
  fix: Email tracking without "use_ssl" (backport #26718) (#26734)
  fix(package_release): set path to tarball
  chore: Reword "Recursive Fetch From" message (#26706) (#26707)
  fix: Skip virtual fields in all select queries (backport #26700) (#26701)
  fix: recursive fetch from causes infinite loop (#26695) (#26696)
  fix: Skip letter heads if no permission (backport #26689) (#26691)
  fix: apply perms on letter head selection (backport #26563) (#26582)
  fix(UX): Disable number card filters on standard (#26676) (#26679)
  test: pin cypress
  fix: fail on cypress install failure
  fix: Auto Email Report not working when Add Total Row is enabled (#26667)
  perf: use base32 space for random names instead of base16 (backport #25497) (#26655)
  fix(make_request): don't blindly try to check the content-type
  ...

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
add-test-cases Add test case to validate fix or enhancement backport version-14-hotfix backport to version 14 backport version-15-hotfix Backport the PR to v15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant